Repository navigation
refactor(router): run SPA navigation from goto instead of tasks - #9091
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 7ab6f19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
@qwik.dev/utils
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
@qwik.dev/mcp
commit: |
Varixo
reviewed
Sep 30, 2026
maiieul
force-pushed
the
claude/router-nav-without-tasks
branch
from
September 30, 2026 15:26
5f80fbd to
fda7cd5
Compare
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
maiieul
force-pushed
the
claude/router-nav-without-tasks
branch
from
October 6, 2026 10:31
fda7cd5 to
4bd631b
Compare
The three router tasks existed to react to navigation signals, so every page serialized them with their captures. goto now loads the route, refreshes loaders, updates the head and commits the page itself. - The server resolves the first head in useQwikRouter, holding back the render with the new internal _waitOn helper. - Loaders ask the router to refresh the head when they get a new value. - Actions start through an internal action-runner context, so the mock provider keeps its own handling.
Varixo
force-pushed
the
claude/router-nav-without-tasks
branch
from
October 6, 2026 15:22
4bd631b to
7ab6f19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
The three router tasks were serialized into every page only so the client could react to navigation signals.
gotonow runs the navigation itself, and SSR waits for the first head through a new internal_waitOncore helper. On the starter's home page, router state drops from 1.7 KB to 1.4 KB.