Repository navigation
Conversation
JSX tag names only hold member chains, so a prop read with a default or a string key (`<props.Model ?? Fallback/>`) failed to parse. Those tags are now rewritten once the JSX is transpiled, as Rust does. Member tags (`<ui.Home/>`) were never rewritten and pointed at the removed destructure.
…rop-jsx-tags-a647ef # Conflicts: # packages/ts-optimizer/src/optimizer/rewrite/raw-props.ts
A child segment rewrote only identifier reads of captured props, so `<Model />` inside `onClick$` kept the removed binding. Its tags now follow the component-body rule: member chains are rewritten in the JSX, and reads with a default or a string key once the JSX is transpiled.
🦋 Changeset detectedLatest commit: 6d77ec8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
@qwik.dev/utils
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
@qwik.dev/mcp
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
maiieul
force-pushed
the
claude/ts-optimizer-prop-jsx-tags-a647ef
branch
2 times, most recently
from
October 5, 2026 09:30
e73f129 to
3e98cb9
Compare
Member
Author
|
Folded into #9127 as its second commit, since both fix destructured props used as JSX tags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
With the TypeScript optimizer, a destructured prop used as a JSX tag inside a
$callback (onClick$={() => render(<Model />)}) kept its bare name, so the segment read an undefinedModel. It now compiles like the Rust optimizer:_jsxSorted(_rawProps.Model ?? Fallback, …).