Repository navigation
fix(router): exclude /manifest.json from the Netlify Edge function - #9187
Merged
Merged
Conversation
The default excluded paths listed /mainifest.json, so requests for /manifest.json still went through the edge function. Fixes QwikDev#8113
🦋 Changeset detectedLatest commit: 470f974 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
approved these changes
Oct 10, 2026
Varixo
left a comment
Varixo
left a comment
Member
There was a problem hiding this comment.
Hello, the PR looks good, thanks!
Varixo
enabled auto-merge
October 10, 2026 21:03
@qwik.dev/core
@qwik.dev/router
@qwik.dev/utils
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
@qwik.dev/mcp
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Fixes #8113. The default excluded paths of the Netlify Edge adapter listed
/mainifest.jsoninstead of/manifest.json, so/manifest.jsonwas still routed to the edge function. This fixes the path in the adapter and in its doc comment, and the generated API docs.Checklist
.changeset/netlify-edge-manifest-path.md,@qwik.dev/routerpatch)