Repository navigation
fix(qwikloader): inline dynamic import under nonce CSP and fix WebKit mid-stream resume - #9208
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2e43622 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
@qwik.dev/utils
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
@qwik.dev/mcp
commit: |
Varixo
reviewed
Oct 13, 2026
Varixo
left a comment
Member
There was a problem hiding this comment.
One more thing related to compatibility caveat remains: deployments using script-src "self" with a fixed set of hashes for existing inline scripts will need to add a hash for the new bootstrap. Could you mention this requirement in the changeset and documentation?
Member
|
Also the other PR can be closed? |
Contributor
Author
Closed
4 tasks done
akasakariko
added a commit
to akasakariko/akasakariko
that referenced
this pull request
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8891
Replaces #9182 and addresses maintainer review requesting multi-browser streaming coverage under enforced nonce CSP
new URL(serializedLoaderURL, document.baseURI).href<as\u003Cin serialized loader path to prevent premature script tag terminationscript-src 'nonce-${nonce}' 'strict-dynamic'header with zero reported CSP violationsVerification
Environment: macOS 26.4.1, Node 24.19.0, pnpm 11.22.0, Playwright 1.61.1 / WebKit 26.5 with
PLAYWRIGHT_BROWSERS_PATH=/Volumes/P600/playwright-browsersPre-fix reproduction on latest main with WebKit skip removed:
Result: 2 failures at loader-ready poll, 1 pass
Post-fix matrix across Chromium, Firefox, and WebKit (both with and without CSP):
Result: 30 passed
Full error handling suite across all browsers:
Result: 126 passed, 6 existing skips
Mutation control:
Temporarily bypassed nonce on bootstrap script under enforced CSP; all 3 engines blocked execution with console violations; restoring nonce returned 30 passed
SSG snapshot tests:
Result: 6 passed, 12 intentional skips for non-Chromium browsers
Focused unit tests:
Result: 93 passed on render and container specs; 2629 passed, 18 skipped, 19 todo on core
Type and build verification:
pnpm build.core.devpassedpnpm build --qwik --optimizer --qwikrouter --eslintpassedpnpm exec tsc -p packages/qwik/tsconfig.json --noEmitpassedpnpm lint.eslintpassedpnpm lint.prettierpassedgit diff --checkpassedValidation Limitations and Caveats
pnpm exec vitest run packages --maxWorkers=4yielded 4001 passed and 7 failures insideplugin.unit.tsdue to missing local Rust wasm bindings (packages/qwik-vite/src/bindings/qwik.wasm.mjs); the same 7 failures reproduced after temporarily reverting ONLY packages/qwik/src/server/ssr-container.ts to base; other test changes remained, so do not claim clean baseQWIK_OPTIMIZER=ts pnpm exec vitest run packages --maxWorkers=1produced 4007 passed and 1 failure on the assertion verifying default Rust optimizer usage due to the environment variable override