Skip to content

fix(ssr): push event names while the page streams - #9226

Merged
Varixo merged 4 commits into
mainfrom
fix/early-event-subscription
Oct 21, 2026
Merged

Varixo merged 4 commits into
mainfrom
fix/early-event-subscription

Conversation

@Varixo

@Varixo Varixo commented Oct 17, 2026

Copy link
Copy Markdown
Member

Event names were pushed to qwikloader only at the end of the document, after the state, so interactions while a large page was still streaming were lost. SSR now pushes newly used event names at the next element open where the inline qwikloader may go. The names come from the render, so passive, useOn and bind events are included. These scripts sit among the app's elements, so they remove themselves after running.

@Varixo Varixo self-assigned this Oct 17, 2026
@Varixo
Varixo requested a review from a team as a code owner October 17, 2026 20:20
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8b60cca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@qwik.dev/core Patch
@qwik.dev/devtools Patch
eslint-plugin-qwik Patch
@qwik.dev/mcp Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
@qwik.dev/utils Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this to Waiting For Review in Qwik Development Oct 17, 2026
@pkg-pr-new

pkg-pr-new Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@9226

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@9226

@qwik.dev/utils

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/utils@9226

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@9226

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@9226

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@9226

@qwik.dev/devtools

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/devtools@9226

@qwik.dev/mcp

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/mcp@9226

commit: 8b60cca

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 8b60cca

Event names were pushed to qwikloader only at the end of the document, after the
state, so interactions while a large page was still streaming were lost. SSR now
pushes newly used event names at the next element open where the inline
qwikloader may go. The names come from the render, so passive, useOn and bind
events are included. These scripts sit among the app's elements, so they remove
themselves after running.
@Varixo
Varixo force-pushed the fix/early-event-subscription branch from f46a487 to de6ea1f Compare October 17, 2026 20:37
@Varixo

Varixo commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

…ription

# Conflicts:
#	packages/qwik/src/core/tests/render-api.spec.tsx

Co-authored-by: Varixo <78650133+Varixo@users.noreply.github.com>

Copilot AI commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved the conflicts with main and pushed merge commit 3c159f5a.

@Varixo
Varixo enabled auto-merge October 20, 2026 07:43
wmertens
wmertens previously approved these changes Oct 20, 2026

@wmertens wmertens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Varixo
Varixo disabled auto-merge October 21, 2026 06:14
@Varixo
Varixo merged commit d9e0405 into main Oct 21, 2026
54 checks passed
@Varixo
Varixo deleted the fix/early-event-subscription branch October 21, 2026 06:15
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants