fix(router): key route bundle graph entries with a trailing slash by Varixo · Pull Request #9304 · QwikDev/qwik

Varixo · 2026-10-26T18:44:02Z

Catch-all names like docs/[...slug] are built without the slash, but every runtime preload lookup adds it, so their bundles never preloaded. Refs #9041.

Summary by CodeRabbit

Bug Fixes
- Fixed bundle preloading for catch-all routes during link prefetch and navigation.

Catch-all names like `docs/[...slug]` are built without the slash, but every runtime preload lookup adds it, so their bundles never preloaded. Refs #9041.

changeset-bot · 2026-10-26T18:44:13Z

🦋 Changeset detected

Latest commit: a937c63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@qwik.dev/router	Patch
eslint-plugin-qwik	Patch
@qwik.dev/mcp	Patch
create-qwik	Patch
@qwik.dev/devtools	Patch
@qwik.dev/react	Patch
@qwik.dev/utils	Patch
@qwik.dev/core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-10-26T18:44:22Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: adb3c771-3e77-4d6d-801f-da6fc5a452c1

Commits

Reviewing files that changed from the base of the PR and between 2240911 and a937c63.

Files selected for processing: 3

.changeset/catch-all-route-preload.md
packages/qwik-router/src/buildtime/vite/get-route-imports.ts
packages/qwik-router/src/buildtime/vite/get-route-imports.unit.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

getRouteImports now adds a trailing slash to route names used as bundle map keys. A unit test covers a catch-all route and updates the subroute snapshot. A changeset records a patch release for @qwik.dev/router.

Changes: Catch-all route preload

Layer / File(s)	Summary
Normalize route import keys `packages/qwik-router/src/buildtime/vite/get-route-imports.ts`, `packages/qwik-router/src/buildtime/vite/get-route-imports.unit.ts`, `.changeset/catch-all-route-preload.md`	`getRouteImports` applies `ensureSlash` to route names used as keys. Tests cover the catch-all route key and update the subroute snapshot to include a trailing slash. The changeset records a patch release.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related issues

QwikDev/qwik#9041: This issue describes the route key mismatch that this change addresses by adding a trailing slash to the build key.

Suggested reviewers: wmertens

Merge Risk: Minimal · up to a937c

The preload-key normalization is compatible with runtime lookups and has focused catch-all coverage, so the PR is ready to merge.

Architecture risk: Low · up to a937c

The change affects 1 system.

Changed systems: packages/qwik-router

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — packages/qwik-router (library) was modified; 2 changed files map to changed impact.

Before / after behavior

observed — Modified behavior in packages/qwik-router/src/buildtime/vite/get-route-imports.ts: Added the ensureSlash import.
observed — Modified behavior in packages/qwik-router/src/buildtime/vite/get-route-imports.ts: Route bundle entries are now keyed by ensureSlash(route.routeName) instead of the unmodified route name.
observed — Modified behavior in packages/qwik-router/src/buildtime/vite/get-route-imports.unit.ts: Adds a test asserting that getRouteImports keys a catch-all route as docs/[...slug]/.
observed — Modified behavior in packages/qwik-router/src/buildtime/vite/get-route-imports.unit.ts: Updates the snapshot’s subroute key from /subroute to /subroute/.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "fix(router): key route bundle graph entries with a trailing slash" matches the main change. The raw summary shows getRouteImports now normalizes route names with ensureSlash before using th…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "fix(router): key route bundle graph entries with a trailing slash" matches the main change. The raw summary shows getRouteImports now normalizes route names with ensureSlash before using them as result keys, and the unit test expects catch-all route imports to use a trailing slash. The PR objectives state that bundle graph entries lacked the trailing slash that runtime preload lookups add, so catch-all route bundles were not preloaded. The title is specific, uses a conventional commit prefix, and is under 72 characters.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-26T18:48:59Z

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@9304

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@9304

@qwik.dev/utils

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/utils@9304

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@9304

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@9304

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@9304

@qwik.dev/devtools

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/devtools@9304

@qwik.dev/mcp

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/mcp@9304

commit: a937c63

github-actions · 2026-10-26T18:54:07Z

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	`a937c63`

Key route bundle graph entries with a trailing slash

a937c63

Catch-all names like `docs/[...slug]` are built without the slash, but every runtime preload lookup adds it, so their bundles never preloaded. Refs #9041.

Varixo requested a review from a team as a code owner October 26, 2026 18:44

maiieul assigned Varixo Oct 26, 2026

maiieul added this to Qwik Development Oct 26, 2026

maiieul moved this from Backlog to Waiting For Review in Qwik Development Oct 26, 2026

github-project-automation Bot moved this to Backlog in Qwik Development Oct 26, 2026

Varixo merged commit b5608b9 into main Oct 26, 2026
56 checks passed

Varixo deleted the fix/9041-catch-all-route-preload branch October 26, 2026 19:10

github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Oct 26, 2026

github-actions Bot mentioned this pull request Oct 26, 2026

V2 Version Packages (rc) #9295

Merged

coderabbitai Bot mentioned this pull request Nov 8, 2026

fix(router): canonical route names for case-insensitive matches #9398

Draft

Navigation Menu

Repository navigation

fix(router): key route bundle graph entries with a trailing slash - #9304

fix(router): key route bundle graph entries with a trailing slash#9304
Varixo merged 1 commit into
mainfrom
fix/9041-catch-all-route-preload

Varixo commented Oct 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 26, 2026

Uh oh!

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Varixo commented Oct 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 26, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Varixo commented Oct 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

github-actions Bot commented Oct 26, 2026 •

edited

Loading