Repository navigation
Conversation
Modular Forms is built with Qwik v1 and does not work with Qwik v2. Formisch is its successor by the same author, so remove the Modular Forms guide, demo and dependency, and redirect its URL to the Formisch guide. Also swap the ecosystem and community project entries.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Update Formisch references packages/docs/src/routes/(ecosystem)/ecosystem.json, packages/docs/src/routes/community/projects/index.mdx, packages/docs/src/routes/docs/integrations/formisch/index.mdx |
The ecosystem and community listings now feature Formisch. The Formisch integration page’s update date, Qwik version note, and fallback link are changed. |
Retire Modular Forms documentation packages/docs/src/routes/docs/integrations/modular-forms/index.mdx, packages/docs/src/routes/demo/integration/modular-forms/index.tsx, packages/docs/src/routes/docs/menu.md, packages/docs/public/_redirects, packages/docs/src/routes/plugin@redirects.ts |
The Modular Forms guide, demo, and menu entry are removed. Both redirect configurations send the old integration URL to Formisch, with the public redirect using status 308. |
Remove Modular Forms package configuration packages/docs/package.json, packages/docs/vite.config.ts |
The docs package no longer lists @modular-forms/qwik as a development dependency or in the specified Vite optimization and server resolution settings. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- QwikDev/qwik#9185: Adds migrate-v2 handling for Qwik 1 libraries and validates an app using
@modular-forms/qwik.
Suggested reviewers: wmertens
Merge Risk: 
021da
-
The documentation migration preserves the legacy URL through a redirect and removes the retired integration consistently.
Security architecture risk: 021da
-
The retired guide redirects to a fixed documentation path on the same site. The existing redirect mechanism is unchanged, and the change does not give visitors control over the destination or introduce a material security risk.
Retained concerns
No architecture-level concerns identified.Security review details
-
Security Blast Radius
- inferred — The added mapping affects navigation to one public documentation path. Its fixed in-site destination does not introduce an attacker-selected external redirect or a privileged operation.
Trust Boundaries and Controls
- observed — For this mapping, the visitor controls the requested pathname but not the redirect destination. The destination is a source-defined relative path; request query parameters and host values are not interpolated into it.
-
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the primary change: replacing the Modular Forms integration with Formisch in the documentation. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (4 skipped: 4 unsupported.)
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
@qwik.dev/core
@qwik.dev/router
@qwik.dev/utils
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
@qwik.dev/mcp
commit: |
|
⚡ Docs preview for 9a828b4 |
What is it?
Description
Modular Forms is built with Qwik v1 and does not work with Qwik v2. Formisch is its successor (same author) and already has an integration guide on the docs. This PR makes Formisch the only form library integration on the v2 docs:
@modular-forms/qwikfrom the docs dependencies and Vite config/docs/integrations/modular-forms/to/docs/integrations/formisch/(308) in both_redirectsandplugin@redirects.tsBlog posts that mention Modular Forms are left unchanged.
packages/insightsstill depends on@modular-forms/qwikand is not touched by this PR.Checklist
pnpm devthat the Formisch guide renders and the old URL redirectsSummary by CodeRabbit