Skip to content

feat(fullsend): move runner Jira access to the Atlassian API gateway - #361

Merged
mrizzi merged 5 commits into
mainfrom
TC-6191
Oct 29, 2026
Merged

mrizzi merged 5 commits into
mainfrom
TC-6191

Conversation

@mrizzi

@mrizzi mrizzi commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The Jira Service Account token (tpa-fullsend-jira-sa) authenticates only through the Atlassian API gateway, using Bearer, or Basic with the suffixed email on record. This PR moves the runner's Jira access onto the gateway.

  • jira-client.py: JIRA_EMAIL is optional. When unset it sends Bearer (the runner); when set it sends Basic (interactive users, unchanged). Adds get_server_info() (cached per process, fails loudly), browse_url(), and a get_server_info CLI subcommand.

  • /browse/ links come from serverInfo.baseUrl in all three builders (execute-actions.py, execute-triage-security-actions.py, pre_triage_security.py discover). They never use the REST base, and the https://jira.invalid fallback is removed.

  • Email is used only by the fullsend CLI: _jira_native_env passes JIRA_USER_EMAIL through unchanged. Neither harness maps JIRA_EMAIL any more, and the pre-scripts no longer require it.

  • Removed the unused env.sandbox.JIRA_BASE_URL from both harnesses.

  • fullsend.md: documents the gateway setup, the suffixed-email requirement, the unsupported-setup caveat and its fallback (docs(#4885): document Jira auth model, token rotation, migration fullsend-ai/fullsend#8678, #4885), the exit condition, an emergency procedure for falling back to a personal token, and a secrets.env sample that matches the harness variables.

  • Re-pinned and re-locked verify-pr to b79eb1b2 in the same PR. triage-security's pin is left alone (it is bumped under TC-7250).

  • Fail-closed gate (TC-7265, from Sourcery/verify-pr review): pre-verify-pr.sh now calls jira-client.py verify_identity before the JQL gate. The run fails unless GET /myself returns an accountId, so a broken credential's empty 200 [] search can no longer become a green ADR-0072 skip.

  • Project-access gate (TC-6191 follow-up): the gate also runs verify_project_access (GET /mypermissions, BROWSE_PROJECTS on JIRA_PROJECT_KEY). A valid account that can't see TC would otherwise also get a filtered [] and skip.

  • Re-pinned and re-locked verify-pr to 02ba46de.

Deviations from the task (agreed during implementation)

  • harness/triage-security.yaml also declares JIRA_USER_EMAIL. Triage comment actions post through post_jira_comment_native, which is the fullsend CLI, so the AC wording "declared only in verify-pr" was wrong.
  • An extra test file, test_triage_security_fullsend.py, got a 2-line fixture stub for get_server_info.
  • _create_and_register fetches serverInfo before create_issue. Without that, a serverInfo failure could leave a sub-task created but never registered (found by code review).

Cutover (before merging)

After this merges the runner sends Bearer, and personal tokens fail with Bearer. Switch CI first:

  1. Set the secrets JIRA_API_TOKEN (Service Account token) and JIRA_EMAIL (suffixed email), and the variable JIRA_BASE_URL (the gateway, https://api.atlassian.com/ex/jira/<cloudId>).
  2. Merge with a merge commit (the content is pinned).
  3. Once a live verify-pr run posts a Jira report comment authored by the Service Account, delete the stale secrets JIRA_SERVER_URL and JIRA_PROJECT_KEY.

Test plan

  • python3 -m pytest plugins/sdlc-workflow/scripts/ -q: 795 passed, 3 skipped
  • uvx skillsaw: 0 errors
  • claude plugin validate plugins/sdlc-workflow: passed
  • Pre-merge: a local fullsend issues post-comment through the gateway with Service Account Basic credentials
  • Post-merge: live verify-pr run posts a report comment authored by the Service Account

Implements TC-6191, TC-7265

🤖 Generated with Claude Code

Summary by Sourcery

Move runner Jira REST access to the Atlassian API gateway while keeping fullsend comment publishing compatible with Service Account credentials.

New Features:

  • Support Jira Service Account authentication through the Atlassian API gateway using Bearer tokens while preserving Basic authentication for interactive users.
  • Add Jira identity, project-access, server-information, and browse-link support to validate credentials and generate site URLs reliably.

Bug Fixes:

  • Prevent unauthenticated or unauthorized Jira searches from being misclassified as valid empty results.
  • Remove invalid browse-link fallbacks and fail when Jira server information cannot provide a site URL.

Enhancements:

  • Update runner and triage harnesses so Jira configuration remains runner-only while the fullsend CLI receives the account email required for comment posting.
  • Fetch and cache Jira server information for human-facing issue links across verification and triage workflows.

CI:

  • Re-pin and re-lock the verify-pr harness to include the updated Jira gateway integration.

Documentation:

  • Document Atlassian API gateway configuration, suffixed Service Account emails, credential cutover, unsupported fullsend setups, and emergency personal-token fallback procedures.

Tests:

  • Expand coverage for authentication schemes, credential validation, server-info caching, browse-link generation, and pre-verification failure behavior.

Chores:

  • Remove obsolete Jira sandbox configuration and no-longer-required runner email mappings.

mrizzi and others added 2 commits October 29, 2026 15:09
The Jira Service Account token authenticates only through the API gateway
(https://api.atlassian.com/ex/jira/<cloudId>), with Bearer or with Basic using
the suffixed email on record.

- jira-client.py: JIRA_EMAIL is optional (unset -> Bearer, set -> Basic);
  add get_server_info() (cached per process, fails loudly) + browse_url()
  and the get_server_info CLI subcommand.
- /browse/ links (execute-actions, execute-triage-security-actions,
  pre_triage_security discover) come from serverInfo.baseUrl, never the
  REST base; the jira.invalid fallback is gone.
- The email reaches only the fullsend CLI: _jira_native_env passes
  JIRA_USER_EMAIL through; both harnesses declare it (triage-security
  comment actions also post via post_jira_comment_native) and no longer
  map JIRA_EMAIL. pre-scripts no longer require JIRA_EMAIL.
- Remove the unused env.sandbox.JIRA_BASE_URL from both harnesses.
- fullsend.md: gateway setup, suffixed email, unsupported-setup caveat
  and fallback, exit condition, emergency personal-token procedure, and
  a secrets.env sample matching the harness variables.

Implements TC-6191

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Implements TC-6191

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Moves runner Jira REST traffic to the Atlassian API gateway with Bearer service-account authentication, keeps Basic credentials isolated to fullsend comment posting, and makes all generated browse links resolve through cached Jira serverInfo while updating harness configuration, operational documentation, tests, and verify-pr pins.

Sequence diagram for gateway Jira reads and browse links

sequenceDiagram
    participant Runner
    participant JiraClient as jira-client.py
    participant Gateway as AtlassianGateway
    participant Jira

    Runner->>JiraClient: search_jql or get_issue
    JiraClient->>Gateway: REST request with Bearer token
    Gateway->>Jira: Forward REST request
    Jira-->>Gateway: Jira response
    Gateway-->>JiraClient: Jira response
    Runner->>JiraClient: browse_url(issue_key)
    JiraClient->>JiraClient: get_server_info()
    JiraClient->>Gateway: GET /rest/api/3/serverInfo
    Gateway->>Jira: Forward serverInfo request
    Jira-->>Gateway: serverInfo.baseUrl
    Gateway-->>JiraClient: serverInfo.baseUrl
    JiraClient-->>Runner: baseUrl/browse/issue_key
Loading

Sequence diagram for fullsend Jira comment authentication

sequenceDiagram
    participant Action as execute-actions.py
    participant Fullsend as FullsendCLI
    participant Gateway as AtlassianGateway
    participant Jira

    Action->>Fullsend: post_jira_comment_native()
    Fullsend->>Gateway: POST Jira comment with Basic email plus token
    Gateway->>Jira: Forward comment request
    Jira-->>Gateway: Comment result
    Gateway-->>Fullsend: Comment result
    Fullsend-->>Action: Post result
Loading

File-Level Changes

Change Details Files
Switch runner-side Jira REST authentication to gateway-compatible Bearer tokens while preserving Basic authentication for interactive and native fullsend comment flows.
  • Make JIRA_EMAIL optional and select Bearer versus Basic authentication from its presence.
  • Pass JIRA_USER_EMAIL only to the fullsend CLI and update both harnesses and scripts accordingly.
  • Document gateway credentials, suffixed service-account email, cutover sequencing, unsupported fullsend setup, and emergency fallback procedures.
plugins/sdlc-workflow/scripts/jira-client.py
plugins/sdlc-workflow/scripts/execute-actions.py
plugins/sdlc-workflow/scripts/pre-verify-pr.sh
plugins/sdlc-workflow/scripts/pre-triage-security.sh
plugins/sdlc-workflow/scripts/post-verify-pr.sh
harness/verify-pr.yaml
harness/triage-security.yaml
fullsend.md
Derive Jira browse links from serverInfo.baseUrl instead of the REST base, with cached lookup and fail-fast behavior.
  • Add cached serverInfo retrieval, browse URL construction, and a CLI subcommand.
  • Update verify-pr actions, triage-security actions, and triage discovery to use site URLs and remove the invalid fallback.
  • Fetch serverInfo before issue creation to avoid unregistered writes when link resolution fails.
plugins/sdlc-workflow/scripts/jira-client.py
plugins/sdlc-workflow/scripts/execute-actions.py
plugins/sdlc-workflow/scripts/execute-triage-security-actions.py
plugins/sdlc-workflow/scripts/pre_triage_security.py
Expand coverage for authentication selection, server-info caching and failures, gateway link generation, harness integration, and CLI behavior.
  • Add unit and integration tests for Bearer/Basic headers, cached serverInfo, malformed responses, and gateway/site bases.
  • Update fixtures and triage fullsend stubs for the new serverInfo dependency.
plugins/sdlc-workflow/scripts/test_jira_client.py
plugins/sdlc-workflow/scripts/test_jira_client_cli.py
plugins/sdlc-workflow/scripts/test_execute_actions.py
plugins/sdlc-workflow/scripts/test_execute_triage_security_actions.py
plugins/sdlc-workflow/scripts/test_pre_triage_security.py
plugins/sdlc-workflow/scripts/test_triage_security_fullsend.py
Re-pin and re-lock the verify-pr harness to the implementation commit and refreshed content hashes.
  • Update the verify-pr base reference and checksum.
  • Refresh lock metadata for the pinned scripts, plugin resources, and dependencies.
.fullsend/harness/verify-pr.yaml
.fullsend/lock.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="plugins/sdlc-workflow/scripts/jira-client.py" line_range="64" />
<code_context>
+    if email:
+        auth_b64 = b64encode(f"{email}:{api_token}".encode('utf-8')).decode('ascii')
+        return f"Basic {auth_b64}"
+    return f"Bearer {api_token}"
+
+
</code_context>
<issue_to_address>
**Invalid Jira access silently skips verification**

When the gateway request is unauthenticated or otherwise returns a successful empty JQL response, `search_jql` can return an empty result without an HTTP error for an unauthenticated request; `pre-verify-pr.sh` passes that result to `resolve-gated-issue`, which treats no matching issue as a normal skip, so the run can finish green without verifying the PR. The shell reports authentication errors only when the Jira client exits nonzero.

Validate Jira identity or otherwise distinguish an unauthenticated empty search from a legitimate no-match result, and fail the run in that case.
</issue_to_address>

### Comment 2
<location path="plugins/sdlc-workflow/scripts/execute-triage-security-actions.py" line_range="80" />
<code_context>
-    base_url = os.environ.get("JIRA_SERVER_URL", "https://jira.invalid").rstrip("/")
-    return "{}/browse/{}".format(base_url, issue_key)
+    """Build a Jira browse URL for a generated issue reference from serverInfo.baseUrl."""
+    return _jira_mod.browse_url(issue_key)


</code_context>
<issue_to_address>
**Retry duplicates created Jira tasks**

When a task creation succeeds but the subsequent serverInfo request fails, a remediation or release-task action can create its Jira issue before `_browse_url` first calls `get_server_info`; if that lookup then fails, execution stops before the reference is registered. A retry can create the same task again, leaving duplicate Jira issues.

Fetch and validate serverInfo before any triage action that creates an issue, before issuing the Jira create request.
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 2 findings to address first, and if the gateway URL or Bearer-versus-Basic selection is wrong, the runner may lose Jira access or perform Jira writes under an unintended identity; reverting restores the prior configuration, but comments or issues already created remain.

Blocking findings: plugins/sdlc-workflow/scripts/jira-client.py:64, plugins/sdlc-workflow/scripts/execute-triage-security-actions.py:80


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

if email:
auth_b64 = b64encode(f"{email}:{api_token}".encode('utf-8')).decode('ascii')
return f"Basic {auth_b64}"
return f"Bearer {api_token}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Invalid Jira access silently skips verification

When the gateway request is unauthenticated or otherwise returns a successful empty JQL response, search_jql can return an empty result without an HTTP error for an unauthenticated request; pre-verify-pr.sh passes that result to resolve-gated-issue, which treats no matching issue as a normal skip, so the run can finish green without verifying the PR. The shell reports authentication errors only when the Jira client exits nonzero.

Validate Jira identity or otherwise distinguish an unauthenticated empty search from a legitimate no-match result, and fail the run in that case.

Prompt for AI agents
In `plugins/sdlc-workflow/scripts/jira-client.py` at line 64:

**Invalid Jira access silently skips verification**

When the gateway request is unauthenticated or otherwise returns a successful empty JQL response, `search_jql` can return an empty result without an HTTP error for an unauthenticated request; `pre-verify-pr.sh` passes that result to `resolve-gated-issue`, which treats no matching issue as a normal skip, so the run can finish green without verifying the PR. The shell reports authentication errors only when the Jira client exits nonzero.

Validate Jira identity or otherwise distinguish an unauthenticated empty search from a legitimate no-match result, and fail the run in that case.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[sdlc-workflow/verify-pr] Classified as code change request — sub-task TC-7265 (https://redhat.atlassian.net/browse/TC-7265) created to address this feedback. The verify-pr gating flow (pre-verify-pr.sh) still treats an authenticated-looking empty JQL result (exit 0, []) as a normal skip, so a run can finish green without verifying the PR; the sub-task adds a fail-closed identity guard before the empty result is honored.

base_url = os.environ.get("JIRA_SERVER_URL", "https://jira.invalid").rstrip("/")
return "{}/browse/{}".format(base_url, issue_key)
"""Build a Jira browse URL for a generated issue reference from serverInfo.baseUrl."""
return _jira_mod.browse_url(issue_key)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Retry duplicates created Jira tasks

When a task creation succeeds but the subsequent serverInfo request fails, a remediation or release-task action can create its Jira issue before _browse_url first calls get_server_info; if that lookup then fails, execution stops before the reference is registered. A retry can create the same task again, leaving duplicate Jira issues.

Fetch and validate serverInfo before any triage action that creates an issue, before issuing the Jira create request.

Prompt for AI agents
In `plugins/sdlc-workflow/scripts/execute-triage-security-actions.py` at line 80:

**Retry duplicates created Jira tasks**

When a task creation succeeds but the subsequent serverInfo request fails, a remediation or release-task action can create its Jira issue before `_browse_url` first calls `get_server_info`; if that lookup then fails, execution stops before the reference is registered. A retry can create the same task again, leaving duplicate Jira issues.

Fetch and validate serverInfo before any triage action that creates an issue, before issuing the Jira create request.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[sdlc-workflow/verify-pr] Classified as code change request — already addressed in this PR, so no sub-task was created. The requested hardening is present: execute-actions.py::_create_and_register now calls _jira_mod.get_server_info() before create_issue (with a comment noting this prevents creating an issue whose key is never registered, which a retry would duplicate), and in the triage-security executor _preflight_plan invokes _browse_url (→ cached get_server_info()) for reference-producing actions before any write, so a serverInfo failure aborts before any issue is created.

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🤖 Finished Verify Pr · ✅ Success · Started 2:17 PM UTC · Completed 2:29 PM UTC

Commit: fdf7b1d · View workflow run →

Runtime: claude · Model: claude-opus-4-8 · Effort: high · Cost: $7.45

@fullsend-ai-review

Copy link
Copy Markdown

[sdlc-workflow/verify-pr] Re: @sourcery-ai[bot] review — this review body restates the two inline comments, classified as follows:

  1. Invalid Jira access silently skips verification (jira-client.py:64) — code change request; sub-task TC-7265 (https://redhat.atlassian.net/browse/TC-7265) created to add a fail-closed identity guard to the gating flow.
  2. Retry duplicates created Jira tasks (execute-triage-security-actions.py:80) — code change request, already addressed in this PR: serverInfo is fetched and validated before any issue-creating write (_create_and_register fetches get_server_info() before create_issue; the triage-security _preflight_plan populates the serverInfo cache before any write). No additional sub-task created.

@fullsend-ai-review

Copy link
Copy Markdown

Verification Report for TC-6191 (commit fdf7b1d)

Check Result Details
Review Feedback WARN 2 code change requests from sourcery-ai[bot]: 1 open (silent-skip on unauthenticated empty Jira search) → sub-task created; 1 already addressed in this PR (serverInfo fetched/validated before issue creation).
Root-Cause Investigation DONE 1 root-cause task created (plan-feature gap: documented fail-open/silent-skip risks must be lowered into verifiable acceptance criteria + tests, not operational mitigations alone).
Scope Containment PASS All 18 changed files map to the task's Files to Modify; no out-of-scope or unimplemented files.
Diff Size PASS +772 / -181 across 18 files; proportionate to a cross-cutting runner Jira-access rework with substantial new tests.
Commit Traceability PASS Both commits reference TC-6191 (Implements trailer).
Sensitive Patterns PASS No secrets/credentials in added lines; all auth tokens env-sourced; literal tokens/emails are example.com test fixtures.
CI Status PASS 7/7 head-SHA check-runs completed with conclusion success; no commit statuses pending/failed.
Acceptance Criteria PASS All code-verifiable criteria met (auth scheme, serverInfo links, email routing, harness env, docs, re-pin/re-lock); remaining items are inherently post-merge/human-operational.
Test Quality PASS Repetitive Test Detection PASS; Test Documentation PASS; Eval Quality: N/A (no eval reviews, no run-evals infra changed).
Test Change Classification ADDITIVE +18 test functions, +41 assertions, +7 parametrize cases; 0 tests/assertions removed; 0 skip annotations. Removed fixture lines target intentionally-removed behavior.
Verification Commands N/A No Verification Commands specified; PR touches no run-evals eval-infrastructure files, so auto-generation does not apply.

Overall: WARN

Overall: WARN

The PR is well-scoped, fully traceable, CI-green, and its acceptance criteria and tests are satisfied for everything verifiable from the diff. One reviewer-flagged defect remains open: the verify-pr gating flow can finish green on an unauthenticated/identity-unverified empty Jira search ([] returned with exit 0), silently skipping verification. A tracked sub-task has been created to add a fail-closed identity guard, and a root-cause task targets the plan-feature phase so documented fail-open risks become verifiable acceptance criteria in future tasks. The second sourcery comment (retry-duplicates-created-tasks) is already resolved in this PR by fetching and validating serverInfo before any issue-creating write.

No code was modified and the PR was not merged — a human reviewer decides whether to merge.


This comment was AI-generated by sdlc-workflow/verify-pr v0.13.10.

mrizzi and others added 3 commits October 29, 2026 16:40
An invalid credential (e.g. a Service Account token off the API gateway)
makes JQL return an empty result with exit 0, which the gate turned into a
green ADR-0072 skip without verifying the PR.

- jira-client.py: add verify_identity() + CLI subcommand; exits non-zero
  unless GET /myself resolves to a non-empty accountId.
- pre-verify-pr.sh: run verify_identity before the JQL gate, so an empty
  search is only honored as a skip once the principal is confirmed; per-run
  mktemp stderr file instead of a fixed /tmp path.
- Tests: verify_identity unit tests, and integration tests running the real
  pre-verify-pr.sh against a local stub Jira (unverified identity + empty
  search fails; verified identity + empty search still skips).

Implements TC-7265

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jira silently drops issues the caller cannot see, so a valid account
without Browse Projects on the project gets 200 [] from the gate's JQL --
indistinguishable from a genuine no-match -- and verify-pr skipped green.

- jira-client.py: add verify_project_access(project_key) + CLI subcommand;
  exits non-zero unless GET /mypermissions grants BROWSE_PROJECTS.
- pre-verify-pr.sh: require JIRA_PROJECT_KEY (pinned TC in the harness)
  and check project access after the identity check, before the search.
- Tests: unit tests for verify_project_access; integration test running
  the real pre-verify-pr.sh against the stub Jira (denied/missing
  permission + empty search fails; granted still skips).
- fullsend.md: document the fail-closed gate and its SA requirements.

Implements TC-6191

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Implements TC-7265
Implements TC-6191

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🤖 Finished Verify Pr · ✅ Success · Started 3:47 PM UTC · Completed 3:55 PM UTC

Commit: f4e27af · View workflow run →

Runtime: claude · Model: claude-opus-4-8 · Effort: high · Cost: $5.57

@fullsend-ai-review

Copy link
Copy Markdown

Verification Report for TC-6191 (commit f4e27af)

Check Result Details
Review Feedback WARN 2 code change requests from sourcery-ai[bot]: 1 → sub-task TC-7265 (created in prior run); 1 already addressed in this PR (serverInfo fetched/validated before issue creation). No new review items this run.
Root-Cause Investigation N/A No new sub-tasks created this run (TC-7265 already existed, idempotency-skipped); root-cause task TC-7266 already filed in the prior run.
Scope Containment WARN All task-listed files present; 2 out-of-scope test files (test_pre_verify_pr.py, test_triage_security_fullsend.py) added for the in-PR sub-task TC-7265 — justified.
Diff Size PASS +1128/-194 across 19 files, proportionate to an ~18-file gateway/auth migration.
Commit Traceability WARN 4 of 5 commits reference TC-6191; commit 271e493 references only sub-task TC-7265.
Sensitive Patterns PASS No secrets in added lines; all token/email matches are test fixtures, env-var name references, or doc placeholders.
CI Status PASS All 6 check-runs succeeded (Script Unit Tests 3.11–3.14, Skill Lint, Plugin Validation); Sourcery review skipped. No commit statuses, no failures.
Acceptance Criteria WARN All code-level criteria satisfied in the diff (Bearer/Basic switch, serverInfo links, JIRA_EMAIL removal, re-pin/re-lock, fullsend.md docs); remaining criteria are operational cutover steps not verifiable from static analysis.
Test Quality PASS Repetitive Test Detection: PASS; Test Documentation: PASS; Eval Quality: N/A.
Test Change Classification ADDITIVE Net new test functions/assertions across 7 modified test files; no coverage weakening.
Verification Commands N/A Task specifies no verification commands; no run-evals infra changes in the diff.

Overall: WARN

No blocking issues. All correctness and security gates pass: CI is green (6/6 check-runs), no secrets detected, and the code-level acceptance criteria and test requirements are met in the diff (optional JIRA_EMAIL→Bearer/Basic auth selection, cached get_server_info() with fail-loud behaviour, serverInfo-based /browse/ links across all three builders, JIRA_USER_EMAIL isolated to the fullsend CLI, sandbox JIRA_BASE_URL removed from both harnesses, re-pin/re-lock, and the fullsend.md gateway documentation).

WARN items are informational:

  • Review Feedback — the two sourcery-ai code-change requests are already handled: one tracked as sub-task TC-7265 (created in the prior run) and fixed in this PR via verify_identity() + verify_project_access() fail-closed gating; the other addressed in-PR by fetching/validating serverInfo before issue creation. No new review items this run.
  • Scope Containment — two extra test files support the in-PR TC-7265 hardening; justified.
  • Commit Traceability — one commit (271e493) references only sub-task TC-7265, not TC-6191; its re-pin sibling f4e27af cites both.
  • Acceptance Criteria — remaining open criteria are operational cutover steps (CI secret switch, local/post-merge live comment posting, repo-secret deletion) that cannot be confirmed from a static diff.

This report is informational — a human reviewer decides whether to merge. This skill does not merge the PR or transition the Jira issue.


This comment was AI-generated by sdlc-workflow/verify-pr v0.13.10.

@mrizzi
mrizzi merged commit 23429a9 into main Oct 29, 2026
18 checks passed
@mrizzi
mrizzi deleted the TC-6191 branch October 29, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant