Skip to content

Render in BG_MODE_3 - #110

Merged
guerinoni merged 5 commits into
mainfrom
bitmap-mode
Nov 7, 2022
Merged

guerinoni merged 5 commits into
mainfrom
bitmap-mode

Conversation

@gallottino

@gallottino gallottino commented Nov 6, 2022 •

Copy link
Copy Markdown
Collaborator

@gallottino
gallottino marked this pull request as ready for review November 6, 2022 02:26
Comment thread ui/src/utilities.rs
Comment thread justfile Outdated
Comment thread ui/Cargo.toml Outdated
Comment thread emu/src/render/lcd.rs
Comment thread emu/src/render/ppu.rs
Comment thread emu/src/render/mod.rs
Comment thread emu/src/gba.rs Outdated
Comment thread emu/src/single_data_transfer.rs
@gallottino
gallottino force-pushed the bitmap-mode branch 3 times, most recently from 5fdae36 to d16bcbd Compare November 7, 2022 10:59
Signed-off-by: gallottino <d.gallotti@outlook.it>
Color is a general abstraction not limited to the palettes.
This implies to implement some conversion for Color32 in ui.

Signed-off-by: gallottino <d.gallotti@outlook.it>
It is the bitmap representation of VRAM.
Each pixels is mapped one to one in the memory.

Signed-off-by: gallottino <d.gallotti@outlook.it>
To test the Bitmap mode a test method was added to verify
that the image is rendered properly.

Signed-off-by: gallottino <d.gallotti@outlook.it>
Signed-off-by: Davide Gallotti <d.gallotti@outlook.it>
@gallottino

Copy link
Copy Markdown
Collaborator Author

Ready for merge now, I think. @AlessioC31 @guerinoni

@guerinoni guerinoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

@guerinoni
guerinoni merged commit 2794a8e into main Nov 7, 2022
@guerinoni
guerinoni deleted the bitmap-mode branch November 7, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants