Repository navigation
Inherit org default PR template - #305
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🔒 Security Scan Complete✅ No security issues detected Scanned files against 45 rules. · Reviewed commit: 📜 Scan history (1 scan)
ℹ️ About PR Security AgentThis scan was performed by PR Security Agent, an automated security review tool for pull requests. See the User Guide for details on severity levels, feedback reactions, and scan configuration. Reply |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe pull request template was deleted. No exported or public declarations changed. ChangesPull request template removal
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The repository will use the organization-wide pull request template. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🛣️ Rokt Platform Paved Roads Scan Complete✅ No paved-road issues detected Scanned files against 2 rules. · Reviewed commit: 📜 Scan history (1 scan)
ℹ️ About Rokt Platform Paved Roads AgentThis scan was performed by the Rokt Platform Paved Roads Agent, an automated paved-road standards review tool for pull requests. See the User Guide for details on severity levels, feedback reactions, and scan configuration. Reply |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
LGTM — this is a straightforward, correct deletion of the repo-local PR template so GitHub falls back to the org default; the inline nit about stale references in CODEOWNERS and select-pr-jobs.sh is cosmetic and doesn't affect behavior.
Extended reasoning...
The diff is a single-file, 28-line deletion of .github/pull_request_template.md with no code, config, or CI logic changes. I confirmed via git diff --stat that this is the only change, and verified the two stale references flagged in the inline findings (.github/CODEOWNERS:6 and .github/scripts/select-pr-jobs.sh:12) — both are glob-style path matchers that will simply never match again since the file no longer exists; this doesn't break CODEOWNERS enforcement or the job-selection script, it just leaves a harmless dangling entry. There are no security implications: no auth, crypto, secrets, or runtime logic is touched. Given the mechanical nature of the change and that the one confirmed finding is a cosmetic nit already surfaced as an inline comment, this warrants approval rather than deferral — a human doesn't need to review a template-file deletion, and the inline nit is enough signal for a follow-up cleanup without blocking this PR.
Additional findings (outside the current diff — GitHub can't attach inline comments there):
-
🟡
.github/CODEOWNERS— nit: Deleting .github/pull_request_template.md leaves two stale references to the removed path, which a maintainer must clean up separately. CODEOWNERS:6 still lists /.github/pull_request_template.md, and .github/scripts/select-pr-jobs.sh:12 still matches .github/pull_request_template.md in its path_scope case statement; both are now dead/no-op since the file can never reappear in a diff. Fix: remove the stale path entries from CODEOWNERS and select-pr-jobs.sh so they don't reference a file that no longer exists.Extended reasoning...
The PR deletes .github/pull_request_template.md but does not touch .github/CODEOWNERS or .github/scripts/select-pr-jobs.sh. CODEOWNERS line 6 still has the entry '/.github/pull_request_template.md' assigning ownership/review requirement to a path that will never exist again. select-pr-jobs.sh line 12 case pattern '.cortex/* | .github/ISSUE_TEMPLATE/* | .github/pull_request_template.md)' includes the deleted path, so that branch of the case can never match going forward. Neither causes an outright failure (git tolerates non-existent CODEOWNERS paths, the case pattern is simply unreachable), but both are stale leftovers of the deletion that should be cleaned up alongside it.
Verification: nit: The candidate accurately identifies two now-stale references left behind by deleting .github/pull_request_template.md.
git diff ... --statconfirms the PR only removes that 28-line file and touches neither of the referencing files. CODEOWNERS:6 still reads/.github/pull_request_template.md(an owner-clearing entry that now matches no file), and select-pr-jobs.sh:12 still lists… | nit:…
Why
This repo carries its own PR template override at
.github/pull_request_template.md, which takes precedence over the shared template at ROKT/.github. New contributors here see a different shape than the rest of the org, and the two copies drift out of sync over time.Programme
Standalone change, no programme.
What changes
Removes the repo-local
.github/pull_request_template.md. With no local override, GitHub falls back to the org-wide default at https://github.com/ROKT/.github/blob/master/.github/PULL_REQUEST_TEMPLATE.MD for every future pull request opened against this repo.Linked work
None.
Rollout
Nothing changes in production; if this is wrong, revert the pull request.
Risks
Risk class: low.
Who
Written by: James Newman.
Code reviewed before opening: Yes — an independent
commit-revieweragent (this repo's local pre-commit gate) reviewed the staged diff for correctness, security, and goal drift, and passed it before this commit was created.Design reviewed before opening: no one.
Decision this implements: sdk-engineering repo-hygiene change to standardize all owned repos on the org default PR template; no ticket.
Checked: Confirmed removing the file leaves GitHub with no repo-level template, verified against GitHub's documented template resolution order.
Not checked: n/a.
Size
Hand-written: 0 lines, 1 file (deletion only).
Generated: none.