Repository navigation
chore: bump actions/download-artifact from 4.3.0 to 8.0.2 - #322
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.3.0 to 8.0.2. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@d3f86a1...9000827) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 8.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
🛣️ Rokt Platform Paved Roads Scan Complete✅ No paved-road issues detected Scanned files against 188 rules. · Reviewed commit: 📜 Scan history (1 scan)
ℹ️ About Rokt Platform Paved Roads AgentThis scan was performed by the Rokt Platform Paved Roads Agent, an automated paved-road standards review tool for pull requests. See the User Guide for details on severity levels, feedback reactions, and scan configuration. Reply |
🔒 Security Scan Complete✅ No security issues detected Scanned files against 71 rules. · Reviewed commit: 📜 Scan history (1 scan)
ℹ️ About PR Security AgentThis scan was performed by PR Security Agent, an automated security review tool for pull requests. See the User Guide for details on severity levels, feedback reactions, and scan configuration. Reply |
There was a problem hiding this comment.
I reviewed this bump and didn't find any bugs. It changes the release workflow that publishes to npm via OIDC, and that path is owned by the workflow code owners, so a human look would still be worthwhile.
What was reviewed:
- Both "Download package artifact" steps in
.github/workflows/release-publish.yml. They still download by exact name intoRokt.Widget/, and the new pin is a full SHA with a version comment. - Compatibility with the upload side:
build-packageuploads with upload-artifact v4.6.2, which produces zipped artifacts. v8's new Content-Type check still unzips these, and the existing sha256 check on the tarball runs after the download. - v8's breaking change, which fails the run on a hash mismatch by default, only makes a corrupted download fail where it used to warn. Separately,
.github/actions/download-and-flattenis still pinned to v4.3.0, so the repo now uses two download-artifact versions.
Extended reasoning...
This is a Dependabot change that moves the actions/download-artifact pin from v4.3.0 to v8.0.2 in two steps of the release-publish workflow. One of those steps runs in the job that has id-token: write for npm trusted publishing. Nothing else changes, and the inputs (name and path) work the same way in v8 for artifacts uploaded with upload-artifact v4. It is a defer rather than an approve because the file sits under .github/workflows/, which CODEOWNERS assigns to a team. It is also the release and publish path that holds OIDC credentials.
Bumps actions/download-artifact from 4.3.0 to 8.0.2.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
9000827Merge pull request #493 from actions/tunc-d-prepare-download-v8-0-2e455989Prepare download-artifact v8.0.2a00b90cMerge pull request #492 from actions/tunc-d-download-artifact-package-bump29bb7ceUpdate@actions/artifactto 6.3.1484a0b5Update the readme (#473)3e5f45bAdd regression tests for CJK characters (#471)e6d03f6Add a regression test for artifact name + content-type mismatches (#472)70fc10cMerge pull request #461 from actions/danwkennedy/digest-mismatch-behaviorf258da9Add change docsccc058eFix linting issuesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)