New component TextFieldEditorWithPopup

[bubblobill]

Identify the Bug or Feature request

resolves #6022

Description of the Change

Needed some better icons, so;

• Added Icons.ACTION_EDIT_IN_EDITOR
• Plus generic directional triangle icons.

and

• Some blank SVG icons containing FlatIconColors.
• Added missing Icons.WARNING

Usual i18n keys added/changed

Removed TextFieldEditorWithPopupTableCellEditor

Added TextFieldEditorWithPopup

TextFieldEditorWithPopup is a container for:

1. a label
2. a toggle button that shows/hides the text field
3. a text field
4. a button to open external text editor (MacroEditorDialog)

Label and Toggle button are both optional and not normally shown, e.g.

Enabling them allows use in other situations such as a toolbar;

Has method to get text field with button as a CellEditor.
Has method to open the component in an input dialogue.

Should work as an Accessibile Component

Possible Drawbacks

none

Documentation Notes

n/a

Release Notes

n/a

---

This change is 

[kwvanderlinde]

I like the new component! I just have a couple requests after doing some tests.

Previously, in Campaign Properties > Token Properties, the cells in the Default columns would automatically switch to a text field on the first click. Now, it either requires a double-click, or to start typing while the cell has focus. Can we restore the single-click behaviour?

I also noticed that after opening and closing the text editor, the popout button gains a yellow background. It also happens if I click and drag the button, and possibly in other circumstances. It doesn't seem to mean anything, though, so would be nice to remove that.

[bubblobill]

I like the new component! I just have a couple requests after doing some tests.

Previously, in Campaign Properties > Token Properties, the cells in the Default columns would automatically switch to a text field on the first click. Now, it either requires a double-click, or to start typing while the cell has focus. Can we restore the single-click behaviour?

Should be doable.

The colour thing is something in my focus handling. Will fix.

[bubblobill]

@kwvanderlinde Sorted. Fixed the colour hanging around when not wanted and single click to edit.