Skip to content

Add error message for wrong PR number - #141

Merged
samad-yar-khan merged 1 commit into
RocketChat:mainfrom
JeffreytheCoder:wrong-pr-number
Mar 25, 2024
Merged

samad-yar-khan merged 1 commit into
RocketChat:mainfrom
JeffreytheCoder:wrong-pr-number

Conversation

@JeffreytheCoder

Copy link
Copy Markdown
Contributor

Issue(s)

Fixes #140

Proposed changes (including videos or screenshots)

wrong_pr_num

@JeffreytheCoder

Copy link
Copy Markdown
Contributor Author

@samad-yar-khan Could you take a look at this PR? Thanks!

@samad-yar-khan samad-yar-khan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffreytheCoder Thanks for this PR. I will merge this atm as it fixes the unhandled bug, but I am hoping all these external calls and error handling will be done by Github sdk in the future to support gh enterprise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Invalid PR number not detected

2 participants