You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@saketkumar95 Hey, man. Expo's version uses a JS based implementation on Android and need a wrapper around entire app in order make it work.
I think it's a little weird.
https://github.com/yfuks/react-native-action-sheet is native (iOS/Android) and needs no render component on the tree. Still needs a work to see if works properly, but it sounds a better choice.
What do you think?
Do you want to contribute?
@reduxsaga There's an open PR here #567.
It's already approved and it'll be merged soon.
If you still want to help, you can find out what's happening on connect/login: #571 and #581.
Activity
saketkumar commentedon Jun 27, 2018
@diegolmello How about using https://github.com/expo/react-native-action-sheet this ?
diegolmello commentedon Jun 27, 2018
@saketkumar95 Hey, man. Expo's version uses a JS based implementation on Android and need a wrapper around entire app in order make it work.
I think it's a little weird.
https://github.com/yfuks/react-native-action-sheet is native (iOS/Android) and needs no render component on the tree. Still needs a work to see if works properly, but it sounds a better choice.
What do you think?
Do you want to contribute?
saketkumar commentedon Jun 27, 2018
yeah that's cool.
And yes I'll be working on this. :)
diegolmello commentedon Jun 27, 2018
@saketkumar95 Great!
diegolmello commentedon Jul 16, 2018
@saketkumar95 Are you still working on this? It's been 15 days since your last commit and your PR still doesn't pass on lint.
diegolmello commentedon Jan 14, 2019
@reduxsaga There's an open PR here #567.
It's already approved and it'll be merged soon.
If you still want to help, you can find out what's happening on connect/login: #571 and #581.