[IMPROVEMENT] Tap on avatar/username/channel to show info #729

Activity

1. diegolmello commented on Mar 15, 2019

   

   diegolmello

   on Mar 15, 2019

   Member

   More actions

   @TheMythPT Totally! A normal press could open RoomInfoView and a long press could open an action sheet with "New Message" and "Info". Maybe "Video call" and "Audio call" (in the future).
2. pranavpandey1998official

   added

   🍭 good first issue

   on May 16, 2019
3. weijia-yu commented on Jun 12, 2019

   

   weijia-yu

   on Jun 12, 2019

   Contributor

   More actions

   I can take this one
4. weijia-yu commented on Jun 13, 2019

   

   weijia-yu

   on Jun 13, 2019

   Contributor

   More actions

   @diegolmello Right now, when we long press the message, it will pop up message actions, should we just add an option "Direct Message"?
5. diegolmello commented on Jun 13, 2019

   

   diegolmello

   on Jun 13, 2019

   Member

   More actions

   @weijia-yu We don't want to create DMs every time.
   We should navigate to RoomInfoView and have an option there to Message.
   Like this:
   

   Feel free to open two PRs instead of one:

   • One just to add "Message" option to RoomInfoView
   • One to navigate on username/channel press
6. weijia-yu commented on Jun 13, 2019

   

   weijia-yu

   on Jun 13, 2019

   Contributor

   More actions

   @diegolmello
   so

   1. Current user room info only has an avatar and timezone, we wanna add "Message"

   2. Currently, if we long press avatar in the channel message, it will detect as long press message. Instead, when we long press users in channel message, it should pop up an actions including "New Message" and "Info"?
7. diegolmello commented on Jun 13, 2019

   

   diegolmello

   on Jun 13, 2019

   Member

   More actions

   @weijia-yu

   1. That's it
   2. Nope. Single taps on avatar/markdown tags (@username/#channel) must navigate to RoomInfoView directly. No need for another actions sheet.
8. weijia-yu commented on Jun 13, 2019

   

   weijia-yu

   on Jun 13, 2019

   Contributor

   More actions

   @diegolmello when will the user click channel avatar? Channel won't appear in chat message, will it? Or in room list, when you click channel avatar, it will go to room info
9. diegolmello commented on Jun 13, 2019

   

   diegolmello

   on Jun 13, 2019

   Last edited by diegolmello

   Member

   More actions

   @weijia-yu

   when will the user click channel avatar?

   Never on the avatar, but the channel name can appear on the message, like #general

   Channel won't appear in chat message, will it?

   Yes, and the user may tap on it.

   Or in room list, when you click channel avatar, it will go to room info

   What do you mean by room list? RoomsListView won't be changed.

   Rules:

   • The user may tap on any avatar and it should navigate to RoomInfoView
   • The user may tap on any username/channel tag parsed by markdown (@username/#channel) and it should navigate to RoomInfoView
   • RoomInfoView must have a "Message" button to navigate to the room:
     • if username: create a DM (if it needed)
     • if channel: navigate to the channel
10. diegolmello

    changed the title [-][Feature] Long press a username avatar could open a option to DM[/-] [+][IMPROVEMENT] Tap on avatar/username/channel to show info[/+] on Jun 13, 2019
11. diegolmello

    added

    👍 improvement

    on Jun 13, 2019
12. diegolmello

    assigned

    pranavpandey1998official

    on Jul 22, 2019
13. pranavpandey1998official commented on Aug 2, 2019

    

    pranavpandey1998official

    on Aug 2, 2019

    Contributor

    More actions

    #1097
14. diegolmello

    closed this as completedin #1097on Aug 22, 2019