Repository navigation
[NEW] Support client certificates for SSL (two-way authentication) - #1125
Merged
Merged
Conversation
djorkaeffalexandre
changed the title
djorkaeffalexandre
marked this pull request as ready for review
August 12, 2019 23:47
|
What if user by mistake removes the certificate from DocumentDir? Couldn't we use app cache to store it? |
Contributor
Author
|
@lorek123 the documents dir is the application dir, not documents folder from iOS. |
IlarionHalushka
suggested changes
Aug 15, 2019
IlarionHalushka
left a comment
IlarionHalushka
left a comment
Contributor
There was a problem hiding this comment.
To tell you the truth I didn't understand much what is going on in this PR but from me a couple of code style comments.
diegolmello
requested changes
Aug 19, 2019
diegolmello
changed the title
diegolmello
approved these changes
Sep 2, 2019
diegolmello
changed the title
|
This pull request introduces 2 alerts when merging d972c7e into 48cdd3b - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
This pull-request adds the ability to connect in servers that uses two-way SSL connections.
We need to make possible to pin certificate on App and use it on WebSocket & Rest API.
Here you can read about SSL Pinning: iOS SSL Pinning
Here we have an issue about that on Rocket.Chat.iOS: RocketChat/Rocket.Chat.iOS#708
new server.login.logout.Closes #1100