Skip to content

[FIX] Replies don't render images - #2564

Closed
vitorl-s wants to merge 7 commits into
RocketChat:developfrom
gces-rocket-chat:new.reply.image
Closed

[FIX] Replies don't render images#2564
vitorl-s wants to merge 7 commits into
RocketChat:developfrom
gces-rocket-chat:new.reply.image

Conversation

@vitorl-s

@vitorl-s vitorl-s commented Oct 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Vitor Leal vitor_leal2201@hotmail.com

Proposed changes

The reply of an image renders a full image in the reply box

Issue(s)

#704

How to test or reproduce

Reply any message

Screenshots

Screen Shot 2020-11-12 at 15 55 55

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@vitorl-s
vitorl-s marked this pull request as draft October 15, 2020 18:36
@lgtm-com

lgtm-com Bot commented Oct 15, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert when merging ef3a88b into b847428 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@CLAassistant

CLAassistant commented Oct 22, 2020 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@vitorl-s
vitorl-s marked this pull request as ready for review October 29, 2020 18:26
@vitorl-s vitorl-s changed the title [WIP] - Replies don't render images [IMPROVEMENT] - Replies don't render images Oct 29, 2020
@djorkaeffalexandre djorkaeffalexandre changed the title [IMPROVEMENT] - Replies don't render images [FIX] Replies don't render images Oct 29, 2020
djorkaeffalexandre
djorkaeffalexandre suggested changes Oct 29, 2020
View reviewed changes
Comment thread app/containers/MessageBox/ReplyPreview.js Outdated
@djorkaeffalexandre

djorkaeffalexandre commented Oct 29, 2020

Copy link
Copy Markdown
Contributor

Make sure of add screenshots of your changes on PR's like this where screenshots can be applied.

vitorl-s and others added 7 commits November 11, 2020 21:10
@vitorl-s
Add Image component
19042b2 
Signed-off-by: Vitor Leal <vitor_leal2201@hotmail.com>
@vitorl-s
Add image on Reply
242a441 
Signed-off-by: Vitor Leal <vitor_leal2201@hotmail.com>
@frclba @vitorl-s
Feat: Add video and audio cases to renderImage in replyPreview to solve
f29845d 
RocketChat#704
@frclba @vitorl-s
Refat: Change variable name in ReplyPreview at function renderImage
c592ddf
@frclba @vitorl-s
Feat: Add extra replyPreview stylesheets
d6609f0
@vitorl-s
Init refactoring replyPreview
c556843 
Signed-off-by: Vitor Leal <vitor_leal2201@hotmail.com>
@vitorl-s
Add img Reply
c704d9a 
Signed-off-by: Vitor Leal <vitor_leal2201@hotmail.com>
@gerzonc

gerzonc commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

It seems to be working fine, can you resolve conflicts? Thanks for your contribution!

@gerzonc gerzonc mentioned this pull request Sep 21, 2021
Closed
5 of 10 tasks
@gerzonc gerzonc mentioned this pull request Mar 14, 2022
Merged
4 of 10 tasks
@diegolmello

diegolmello commented Mar 15, 2022

Copy link
Copy Markdown
Member

Closing in favor of #3883

@diegolmello
diegolmello deleted the new.reply.image branch March 15, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djorkaeffalexandre djorkaeffalexandre Awaiting requested review from djorkaeffalexandre

Assignees

No one assigned

Labels

🛠 fix 🚨 needs changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vitorl-s @CLAassistant @djorkaeffalexandre @gerzonc @diegolmello @frclba