Repository navigation
[FIX] Make sure messages are loading properly - #3227
Merged
Merged
Conversation
diegolmello
reviewed
Jul 2, 2021
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [FIX] Conditional to compare the server version and filter or not the system messages * instead of lowerThanOrEqualTo using lowerThan * To do a reactive message list * minor tweaks Co-authored-by: Gerzon Z <gerzonc@icloud.com> Co-authored-by: Diego Mello <diegolmello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Conditional to compare the server version and filter or not the system messages
With the new update in backend RocketChat/Rocket.Chat#22364 , now the app doesn't need to filter the messages array to hide the system messages.
Issue(s)
Related #2393
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments