Skip to content

Chore: Migrate lib user preferences to Typescript #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 4 commits into from
Jan 11, 2022
Merged

Chore: Migrate lib user preferences to Typescript #3578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03a937a
chore: migrate userPreferents to ts
dnlsilva Dec 27, 2021
62b323c
fix: fix logic to browser const to remove null option
dnlsilva Dec 27, 2021
3ddd565
Update userPreferences.ts
dnlsilva Dec 29, 2021
1d3337b
Merge branch 'develop' into chore/migrate-lib-user-preferences-to-ts
diegolmello Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions app/lib/userPreferences.js → app/lib/userPreferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ const MMKV = new MMKVStorage.Loader()
.initialize();

class UserPreferences {
private mmkv: MMKVStorage.API;
constructor() {
this.mmkv = MMKV;
}

async getStringAsync(key) {
async getStringAsync(key: string) {
try {
const value = await this.mmkv.getStringAsync(key);
return value;
Expand All @@ -20,11 +21,11 @@ class UserPreferences {
}
}

setStringAsync(key, value) {
setStringAsync(key: string, value: string) {
return this.mmkv.setStringAsync(key, value);
}

async getBoolAsync(key) {
async getBoolAsync(key: string) {
try {
const value = await this.mmkv.getBoolAsync(key);
return value;
Expand All @@ -33,11 +34,11 @@ class UserPreferences {
}
}

setBoolAsync(key, value) {
setBoolAsync(key: string, value: boolean) {
return this.mmkv.setBoolAsync(key, value);
}

async getMapAsync(key) {
async getMapAsync(key: string) {
try {
const value = await this.mmkv.getMapAsync(key);
return value;
Expand All @@ -46,11 +47,11 @@ class UserPreferences {
}
}

setMapAsync(key, value) {
setMapAsync(key: string, value: object) {
return this.mmkv.setMapAsync(key, value);
}

removeItem(key) {
removeItem(key: string) {
return this.mmkv.removeItem(key);
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/views/DefaultBrowserView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class DefaultBrowserView extends React.Component<IDefaultBrowserViewProps, IDefa
changeDefaultBrowser = async (newBrowser: TValue) => {
logEvent(events.DB_CHANGE_DEFAULT_BROWSER, { browser: newBrowser });
try {
const browser = newBrowser !== 'systemDefault:' ? newBrowser : null;
const browser = newBrowser || 'systemDefault:';
await UserPreferences.setStringAsync(DEFAULT_BROWSER_KEY, browser);
this.setState({ browser });
} catch {
Expand Down