Skip to content

Use Rest API calls - #558

Merged
diegolmello merged 34 commits into
developfrom
temp-sdk
Dec 5, 2018
Merged

diegolmello merged 34 commits into
developfrom
temp-sdk

Conversation

@diegolmello

Copy link
Copy Markdown
Member

@RocketChat/ReactNative

@ghost ghost changed the title [WIP] Use Rest API calls Use Rest API calls Dec 5, 2018
@ghost
ghost merged commit a2821af into develop Dec 5, 2018
@ghost
ghost deleted the temp-sdk branch December 5, 2018 20:52

ghost commented Dec 6, 2018

Copy link
Copy Markdown

i will test and give my findings, good work so far.

ghost commented Dec 6, 2018 •

Copy link
Copy Markdown

My feedback:

  1. Overall the app looks a bit slow in doing actions as compared to the native kotlin android app. Like opening images, loading old chats , opening a room for first time. etc Why its not fast like fb messenger, when these both apps r on react native.

  2. Long and fast scroll down on files attachment page still shows a blank white page. Unable to fully scroll to the end of the files attachments. it shows re scrolls mid way on top.

  3. i tested these changes on 1.6.1.5184

  4. Is this the same app for iOS react native too? or the iOS one is more stable? Which i0S version should we deploy for production, the native swift one for iOS or the react native one for iOS.?

  5. It takes a bit long time to retrieve the old messages convo when opening a DM room for first time. but thankfully on new DMs , now the app is not crashing :)

  6. There is a slight lag when i send the message and it get sent, may be i m being too optimistic and its just my network.

Over all good work, the only thing is lag in the overall app usage is bad for UX.

Once my team tests and give more feedback, i will update.

@ghost ghost mentioned this pull request Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants