Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Avatars aren't loaded if unauthenticated access to avatars is disabled. #2540

Closed
Closed
[NEW] Avatars aren't loaded if unauthenticated access to avatars is disabled.#2540
Assignees
rafaelks
Labels
🎉 feature
Milestone
3.4.0

Description

@davidlougheed
davidlougheed
opened on Feb 7, 2019
  • Your Rocket.Chat app version: 3.3.0
  • Your Rocket.Chat server version: 0.74.0
  • Device (or Simulator) you're running with: iPhone 8

The server provides a setting to disable unauthenticated access to avatars. If this is enabled, avatars are not loaded by the iOS app (see RocketChat/Rocket.Chat.ReactNative#603 and RocketChat/Rocket.Chat.Android#1749 )

I'm working on a fix for the React Native client (see RocketChat/Rocket.Chat.ReactNative#604 ) but it would be nice to see the same fixes in the other apps.

To fix this, pass rc_token and rc_uid as URL params when fetching the avatar via URL.

Activity

  1. rafaelks
    added this to the 3.4.0 milestone on Feb 7, 2019
  2. rafaelks
    added
    🎉 feature
    on Feb 7, 2019
  3. rafaelks
    self-assigned this
    on Feb 12, 2019
  4. rafaelks
    changed the title [-]Avatars aren't loaded if unauthenticated access to avatars is disabled.[/-] [+][NEW] Avatars aren't loaded if unauthenticated access to avatars is disabled.[/+] on Feb 12, 2019
  5. rafaelks
    closed this as completedin #2591on Mar 20, 2019

  6. davidlougheed commented on Mar 29, 2019

    @davidlougheed
    davidlougheed
    on Mar 29, 2019
    Author

    @rafaelks this works for users but not channel icons (same problem, same endpoint as far as I know) in the latest dev build, so it's not fully fixed

  7. rafaelks commented on Mar 29, 2019

    @rafaelks
    rafaelks
    on Mar 29, 2019
    Contributor

    @davidlougheed True, it needs to be fixed for channels as well 👍

  8. rafaelks commented on Mar 29, 2019

    @rafaelks
    rafaelks
    on Mar 29, 2019
    Contributor

    @davidlougheed Fixed here: #2620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🎉 feature

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions