Repository navigation
[IMPROVE] don't include system messages in endpoint response when they're filtered out in room settings - #20442
Closed
gabrieleiro wants to merge 3 commits into
Closed
gabrieleiro wants to merge 3 commits into
gabrieleiro wants to merge 3 commits into
Conversation
Member
|
Depends on #20512 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
the message history endpoints always include all system messages from that room even when they're filtered in the room settings. this pr will make the server return only the messages that should show up in the ui.
Issue(s)
Steps to test or reproduce
Further comments