Repository navigation
[FIX] Add an overflow for multiple quoted messages to stop hiding the messages behind if there is multiple quoted messages - #21903
Closed
Jeanstaquet wants to merge 32 commits into
Closed
Jeanstaquet wants to merge 32 commits into
Jeanstaquet wants to merge 32 commits into
Conversation
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Upating the fork
Updating fork
Updating fork
Updating fork
Updating Fork
Updating fork
Updating fork
Updating fork
Updating fork
Updating fork
Update branch
Jeanstaquet
changed the title
Contributor
Author
|
Hello @dougfabris can you review please ? Thanks a lot :) |
Jeanstaquet
changed the title
Jeanstaquet
changed the title
|
|
Member
|
Hi there, thanks for the contribution! 🚀 💯 Closing this PR because it's duplicated now and it has been fixed in another one. #27604 Questions? Help needed? Feature Requests?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
For the issue #21892, I've added overflow-y so that if you quote too many messages it doesn't hide the messages behind them. Its's 80px per quoted messages. So actually we will show 3 of them at the same time.
2021-05-01.01-19-52.mp4
With big messages after:
2021-05-03.00-49-29.mp4
Issue(s)
Fixes #21892
Steps to test or reproduce
Further comments
Let me know if i should increase the number of quoted messages