Repository navigation
[FIX][EE] Canned responses can't be deleted - #22095
Merged
Merged
Conversation
rafaelblink
changed the title
rafaelblink
marked this pull request as ready for review
May 20, 2021 23:05
rafaelblink
changed the title
renatobecker
requested changes
May 20, 2021
renatobecker
left a comment
renatobecker
left a comment
Contributor
There was a problem hiding this comment.
The deletion process works fine, but the button is placed on the CannedResponsesForm form and the right place is CannedResponseDetails.
renatobecker
approved these changes
May 31, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Deletion button has been removed from the edition option.
Before
After
Issue(s)
Steps to test or reproduce
Further comments