Repository navigation
[FIX] General Avatar Format Issue - #24906
Closed
nishant23122000 wants to merge 4 commits into
Closed
nishant23122000 wants to merge 4 commits into
nishant23122000 wants to merge 4 commits into
Conversation
Contributor
Author
|
Hey @sampaiodiego and @tassoevan can you review this PR? |
Contributor
Author
|
@debdutdeb and @murtaza98 please check that one also. |
Member
|
Hi there, thanks for the contribution! 🚀 💯 Closing this PR because it's stale now and it was already fixed here: #25912. Questions? Help needed? Feature Requests?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
PR Number #24226 was only focused on the user profile avatar.
After realizing that the avatar file format issue is also occurring inside discussion, team, channel.
Issue(s)
Check issue #24213, which was only focused on the profile avatar format issue.
Steps to test or reproduce
Further comments
We can not combine the profile avatar format issue and that one in one logic, because the profile avatar issue and other rooms have different file structures inside the codebase.
Discussion,team,channel using :https://github.com/RocketChat/Rocket.Chat/tree/develop/client/components/avatar
Profile avatar section using: https://github.com/RocketChat/Rocket.Chat/tree/develop/client/components/avatar/UserAvatarEditor