Skip to content

[FIX] Unable to remove a user who joined a public team with a mention - #26218

Merged
kodiakhq[bot] merged 15 commits into
developfrom
fix/remove-user-from-mention
Aug 16, 2022
Merged

[FIX] Unable to remove a user who joined a public team with a mention#26218
kodiakhq[bot] merged 15 commits into
developfrom
fix/remove-user-from-mention

Conversation

@LucianoPierdona

@LucianoPierdona LucianoPierdona commented Jul 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

This PR fixes a bug where a user that joins a team by mention don't get added to the team.

Issue(s)

Fix #25817

Steps to test or reproduce

  1. Go to the team creation menu. Switch the private setting to off. Create a team.
  2. Mention user with @. The user is added.
  3. Remove user from the team.
  4. The user is not deleted. A Bad Request error appears.

Further comments

@LucianoPierdona LucianoPierdona self-assigned this Jul 11, 2022
@LucianoPierdona
LucianoPierdona marked this pull request as ready for review July 12, 2022 20:53
@alvaropmello alvaropmello added this to the 5.0.1 milestone Jul 21, 2022
matheusbsilva137
matheusbsilva137 suggested changes Jul 27, 2022
View reviewed changes
Comment thread apps/meteor/app/lib/server/lib/sendNotificationsOnMessage.js Outdated
matheusbsilva137
matheusbsilva137 suggested changes Jul 28, 2022
View reviewed changes
Comment thread apps/meteor/app/lib/server/functions/addUserToRoom.ts Outdated
@codecov

codecov Bot commented Jul 28, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #26218 (a568881) into develop (1928374) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head a568881 differs from pull request most recent head d157c10. Consider uploading reports for the commit d157c10 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26218      +/-   ##
===========================================
+ Coverage    38.60%   38.65%   +0.05%     
===========================================
  Files          758      758              
  Lines        18820    18816       -4     
  Branches      1452     1459       +7     
===========================================
+ Hits          7266     7274       +8     
+ Misses       11334    11322      -12     
  Partials       220      220
Flag Coverage Δ
e2e 38.65% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@alvaropmello alvaropmello modified the milestones: 5.0.1, 5.1.0 Jul 28, 2022
matheusbsilva137
matheusbsilva137 suggested changes Aug 15, 2022
View reviewed changes
Comment thread apps/meteor/server/services/team/service.ts Outdated
@matheusbsilva137 matheusbsilva137 changed the title [FIX] Remove user from public team when joined with mention [FIX] Unable to remove a user who joined a public team with a mention Aug 15, 2022
@LucianoPierdona LucianoPierdona added stat: ready to merge PR tested and approved waiting for merge stat: QA tested and removed stat: needs QA labels Aug 16, 2022
@kodiakhq
kodiakhq Bot merged commit 643e818 into develop Aug 16, 2022
@kodiakhq
kodiakhq Bot deleted the fix/remove-user-from-mention branch August 16, 2022 18:11
@LucianoPierdona LucianoPierdona mentioned this pull request Aug 17, 2022
Closed
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@LucianoPierdona @matheusbsilva137 csuarez
[FIX] Unable to remove a user who joined a public team with a mention (…
87f0092 
…#26218)

Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@matheusbsilva137 matheusbsilva137 matheusbsilva137 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LucianoPierdona LucianoPierdona

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

Unable to remove an invited user from a public team

4 participants

@LucianoPierdona @matheusbsilva137 @alvaropmello @tassoevan