Skip to content

[FIX] Default BH not getting applied in-case any other BH is disabled - #26471

Merged
kodiakhq[bot] merged 10 commits into
developfrom
omni/bh-default-no-applied-1
Aug 17, 2022
Merged

kodiakhq[bot] merged 10 commits into
developfrom
omni/bh-default-no-applied-1

Conversation

@murtaza98

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Pre-requisite:

  • Have Multiple Business hours enabled
  • Have exactly 2 BH setups and one of them should be linked to a department which has an agent

To reproduce this issue:

  1. Login as an agent which is connected to a department (lets say Sales) which is again connected to a BH (let's call it ET)
  2. Modify the Default Business hour time to make it active and make the other BH inactive
  3. Try to enable the agent now and you should see an error saying that the BH is closed which is expected since this Sales department has BH closed right now (we closed it in step 2)
  4. Now disable this other BH. And try to make this agent available again.

Actual behaviour:
Agent is getting error saying BH is closed

Expected behaviour:
Agent should be able to make itself available since the default BH should be applied to him/her - considering the other BH (ET) is disabled

Further comments

Clickup: https://app.clickup.com/t/2gabfqd

@codecov

codecov Bot commented Aug 4, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #26471 (371d44f) into develop (f28db32) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 371d44f differs from pull request most recent head 8803032. Consider uploading reports for the commit 8803032 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26471      +/-   ##
===========================================
+ Coverage    38.62%   38.72%   +0.09%     
===========================================
  Files          758      758              
  Lines        18823    18816       -7     
  Branches      1453     1459       +6     
===========================================
+ Hits          7271     7286      +15     
+ Misses       11336    11310      -26     
- Partials       216      220       +4     
Flag Coverage Δ
e2e 38.72% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98
murtaza98 requested a review from a team as a code owner August 16, 2022 04:39
@murtaza98
murtaza98 force-pushed the omni/bh-default-no-applied-1 branch from b8586ee to 70463e5 Compare August 16, 2022 11:30
@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 16, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 17, 2022
@kodiakhq
kodiakhq Bot merged commit 5bca39e into develop Aug 17, 2022
@kodiakhq
kodiakhq Bot deleted the omni/bh-default-no-applied-1 branch August 17, 2022 13:01
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants