Repository navigation
[NEW] Sections layout and featured apps for marketplace - #26514
Merged
Merged
Conversation
Created the /featured endpoints on the rest.js file. Also created the necessary typings to use together with it.
…red-apps-endpoint
Fixed a problem in which the featured endpoint would be out prioritized by the rest client because it was bellow a wildcard endpoint. Also solved a typo on the route definition for the featured endpoint.
Refactored the AppsList and surrounding components so that they can be reused for more than one list of apps and start the creation of the new sections.
Consumed the response from the /featured endpoint, created a normalization function for the apps list of the sections and created the necessary types to make it all work.
…ections Implemented the on search and on load behavior for the new featured apps sections and solved some missing key problems.
…t/Rocket.Chat into feat/featured-apps-marketplace
rique223
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #26514 +/- ##
===========================================
- Coverage 40.42% 40.41% -0.02%
===========================================
Files 798 798
Lines 18277 18277
Branches 1959 1959
===========================================
- Hits 7389 7387 -2
- Misses 10592 10594 +2
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. |
Implemented the logic for the featured apps sections to hide when the filters are used
rique223
changed the title
Changed the styles of the marketplace apps page tabs to make it closer to the figma design
ggazzo
previously requested changes
Aug 12, 2022
ggazzo
left a comment
ggazzo
left a comment
Member
There was a problem hiding this comment.
its not a good practice put a bunch of <Box ....props> around you application code.
its recommended to create a 'custom component' like "FeaturedAppSectionItem" and them there you are allowed to use some styling
The url of the featured endpoint was causing a problem on the back-end, changed the url to v1/featured-apps to solve this problem. Also solved Gazzos reviews.
geekgonecrazy
dismissed
ggazzo’s stale review
September 6, 2022 22:04
A lot has changed since this review.
ggazzo
force-pushed
the
feat/featured-apps-marketplace
branch
from
September 7, 2022 05:07
3a08245 to
1b1fd62
Compare
ggazzo
force-pushed
the
feat/featured-apps-marketplace
branch
from
September 7, 2022 05:38
1b1fd62 to
365b864
Compare
ggazzo
previously approved these changes
Sep 8, 2022
Fixed a bug in the Apps page pagination in which the pagination appeared in the installed page even though there were no installed apps. Also erased a duplicated boolean and solved a misalignment between the data badge component and the install/buy button.
ggazzo
approved these changes
Sep 8, 2022
graywolf336
approved these changes
Sep 9, 2022
d-gubert
approved these changes
Sep 9, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
MKP??+ - Featured Apps
Implemented a new layout for marketplace's apps list page. Now the page has an All apps section and a "featured apps" section in which pre-selected and pre-categorized apps are dynamically shown on the top area of the page to make them stand out.
Demo gif:
ClickUp Task link: https://app.clickup.com/t/2t1w9x3
Issue(s)
Steps to test or reproduce
Further comments