Skip to content

Chore: Improve test for livechat - #26527

Merged
kodiakhq[bot] merged 15 commits into
developfrom
test/omni-livechat
Aug 10, 2022
Merged

kodiakhq[bot] merged 15 commits into
developfrom
test/omni-livechat

Conversation

@weslley543

Copy link
Copy Markdown
Contributor
  • Improve test for livechat

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Comment thread apps/meteor/tests/e2e/omnichannel-livechat.spec.ts
Comment thread apps/meteor/tests/e2e/omnichannel-livechat.spec.ts Outdated
Comment thread apps/meteor/tests/e2e/page-objects/omnichannel-livechat.ts Outdated
Comment thread apps/meteor/tests/e2e/utils/create-aux-chatcontext.ts Outdated
Comment thread apps/meteor/tests/e2e/utils/create-aux-chatcontext.ts
@codecov

codecov Bot commented Aug 9, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #26527 (afe6826) into develop (4635fae) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head afe6826 differs from pull request most recent head 46c7429. Consider uploading reports for the commit 46c7429 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26527      +/-   ##
===========================================
+ Coverage    38.05%   38.20%   +0.15%     
===========================================
  Files          749      762      +13     
  Lines        18667    18863     +196     
  Branches      1455     1463       +8     
===========================================
+ Hits          7103     7207     +104     
- Misses       11343    11432      +89     
- Partials       221      224       +3     
Flag Coverage Δ
e2e 38.20% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

souzaramon
souzaramon previously approved these changes Aug 9, 2022
@weslley543
weslley543 marked this pull request as ready for review August 9, 2022 18:10
@weslley543
weslley543 requested a review from a team as a code owner August 9, 2022 18:10

@tassoevan tassoevan left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the element selectors are quite fragile... Should we do some iteration with @RocketChat/omnichannel to improve them?

It's a work for later.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 10, 2022
@kodiakhq
kodiakhq Bot merged commit 3c1cee7 into develop Aug 10, 2022
@kodiakhq
kodiakhq Bot deleted the test/omni-livechat branch August 10, 2022 15:17
gabriellsh added a commit that referenced this pull request Aug 12, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits)
  Chore: update fuselage rounded edition  (#26540)
  [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535)
  [FIX] Allow normal user to open apps contextual bar (#26495)
  Chore: restrict `.only` (#26537)
  [FIX] Endpoints not working when using "Use Real Name" setting (#26530)
  [NEW] `Home` page (#25734)
  Chore: ModalFooterControllers adoption (#26445)
  Chore: create roomNameExists endpoint (#26386)
  Chore: Improve test for livechat  (#26527)
  Chore: Fix UiKit dependency issue for Livechat (#26534)
  [FIX] Too many REST API requests (#26330)
  Chore: Mocha handling multiple React instances (#26513)
  Chore: Convert `LivechatCustomField` model to raw model (#26446)
  i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508)
  [FIX] Open team after room not found page (#26264)
  Chore: Refactor ReportMessage Modal to React Component (#26478)
  Chore: Fix lint issues (#26531)
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants