Repository navigation
[FIX] Auto Translate not working on new message template - #27317
Merged
Merged
Conversation
|
This pull request introduces 1 alert when merging b90ea63 into b816803 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
filipemarins
force-pushed
the
tc-223
branch
2 times, most recently
from
November 22, 2022 15:29
244e91a to
6d1f466
Compare
filipemarins
marked this pull request as ready for review
November 22, 2022 15:29
gabriellsh
requested changes
Nov 22, 2022
gabriellsh
left a comment
gabriellsh
left a comment
Member
There was a problem hiding this comment.
When sending an attachment, the description was not translated in the main room, but was in the thread.
Codecov Report
@@ Coverage Diff @@
## develop #27317 +/- ##
===========================================
- Coverage 42.90% 42.88% -0.03%
===========================================
Files 814 817 +3
Lines 17199 17234 +35
Branches 1923 1934 +11
===========================================
+ Hits 7380 7391 +11
- Misses 9563 9579 +16
- Partials 256 264 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
Inside the thread, we are having the wrong behavior, we should not translate our own message. I was only focused on the main message list but nice catch, I will fix it on the thread. |
gabriellsh
previously approved these changes
Nov 24, 2022
gabriellsh
left a comment
gabriellsh
left a comment
Member
There was a problem hiding this comment.
Since this is a very large PR on an important feature, I'll ask for an additional review.
hugocostadev
previously approved these changes
Dec 7, 2022
gabriellsh
previously requested changes
Jan 4, 2023
tassoevan
requested changes
Jan 9, 2023
tassoevan
previously approved these changes
Jan 12, 2023
dionisio-bot
Bot
added
stat: ready to merge
tassoevan
approved these changes
Jan 16, 2023
gabriellsh
added a commit
that referenced
this pull request
Jan 16, 2023
…ixSearch * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Show different labels based on the call originator on direct calls (#27729) Chore: Change bundle tags color and refactor app details page header styles (#27293) [FIX] Auto Translate not working on new message template (#27317) Chore: Custom Sounds Empty State (#27632) [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556) Regression: Broken room and message composer events (#27754) [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699) [IMPROVE] SAML and OAuth role sync to support id and name (#27405) Chore: add e2e test coverage for Video Conference (#27075) Chore: Invites Empty State (#27631) [FIX] Marketplace app status initially disabled (#27330) Regression: Missing contexts on contextual bar (#27734)
Merged
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
closes #27567
Steps to test or reproduce
Further comments
I had to move
useAutoTranslateanduseKatexto a separate hook cause onMessageListcomponent the context isn't fulfilled yet.Quote attachment
Multilevel quote attachments get translated as well:
But if you try to translate a message that wasn't translated yet and has multiple levels of quote message it will only translate the first quote message...
ThreadMessagePreview component translated