Skip to content

[FIX] Register Workspace UI fixes and fix doc link - #28021

Merged
geekgonecrazy merged 5 commits into
developfrom
fix/CS-344-register-workspace-token
Feb 14, 2023
Merged

geekgonecrazy merged 5 commits into
developfrom
fix/CS-344-register-workspace-token

Conversation

@csuadev

@csuadev csuadev commented Feb 13, 2023

Copy link
Copy Markdown
Contributor
  • Add error label on register with token
  • Add success toast on resend register email.
  • Fix documentation link.
  • Fix translation error.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@csuadev
csuadev requested a review from a team as a code owner February 13, 2023 20:48
Comment thread apps/meteor/client/views/admin/cloud/modals/RegisterWorkspaceModal.tsx Outdated
Comment thread apps/meteor/client/views/admin/cloud/modals/RegisterWorkspaceModal.tsx Outdated
@codecov

codecov Bot commented Feb 13, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #28021 (7660469) into develop (35705ae) will increase coverage by 2.21%.
The diff coverage is 54.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28021      +/-   ##
===========================================
+ Coverage    42.09%   44.31%   +2.21%     
===========================================
  Files          813      787      -26     
  Lines        17861    15741    -2120     
  Branches      2031     1960      -71     
===========================================
- Hits          7519     6975     -544     
+ Misses       10052     8489    -1563     
+ Partials       290      277      -13     
Flag Coverage Δ
e2e 44.31% <54.62%> (+2.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

geekgonecrazy
geekgonecrazy previously approved these changes Feb 13, 2023
@geekgonecrazy geekgonecrazy added this to the 6.0.0 milestone Feb 13, 2023
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 14, 2023
@geekgonecrazy geekgonecrazy removed the stat: ready to merge PR tested and approved waiting for merge label Feb 14, 2023
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 14, 2023
@geekgonecrazy
geekgonecrazy merged commit 7898e49 into develop Feb 14, 2023
@geekgonecrazy
geekgonecrazy deleted the fix/CS-344-register-workspace-token branch February 14, 2023 19:40
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants