Repository navigation
Regression: Small fixes to installation flow - #28160
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28160 +/- ##
===========================================
- Coverage 44.84% 39.51% -5.33%
===========================================
Files 764 743 -21
Lines 14897 14678 -219
Branches 2069 2031 -38
===========================================
- Hits 6680 5800 -880
- Misses 7924 8603 +679
+ Partials 293 275 -18
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
changed the title
dionisio-bot
Bot
added
the
stat: ready to merge
rique223
previously approved these changes
Feb 27, 2023
kodiakhq
Bot
removed
the
stat: ready to merge
Contributor
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
…ct-enabled-status
dionisio-bot
Bot
added
the
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
rique223
approved these changes
Feb 28, 2023
dionisio-bot
Bot
added
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Some UI fixes on app installation flow:
Some apps were being incorrectly shown as "Enabled"
App status
INITIALIZEDwas wrongly considered as meaning an app was "Enabled". That's not the case.It was introduced there to mark apps as "installed", but this is not the case anymore. [FIX] Marketplace app status initially disabled #27330 wanted to solve the situation where an app was initially shown as disabled right after it was installed, and a different solution to this will be provided by changing how Apps-Engine communicates status changes to the UI.
Some installed apps in the "Installed" screen incorrectly not being displayed as grandfathered
Installation modal being shown in EE where it shouldn't
Installation modal showed wrong label when installing apps from Marketplace
Issue(s)
Steps to test or reproduce
Further comments
MKP-245
MKP-248
MKP-251
MKP-259
MKP-262
MKP-264