Repository navigation
fix!: "Forgot Password" e-mail is not translated correctly - #32212
Merged
matheusbsilva137 merged 10 commits intoOct 11, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e8dcd3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32212 +/- ##
================================================
Coverage ? 75.69%
================================================
Files ? 430
Lines ? 19893
Branches ? 5078
================================================
Hits ? 15059
Misses ? 4264
Partials ? 570
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
marked this pull request as ready for review
April 15, 2024 17:57
gabriellsh
previously approved these changes
Apr 15, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
matheusbsilva137
dismissed
gabriellsh’s stale review
April 19, 2024 16:07
The base branch was changed.
dionisio-bot
Bot
removed
the
stat: ready to merge
ggazzo
force-pushed
the
release-7.0.0
branch
2 times, most recently
from
April 24, 2024 14:34
472825d to
68fee68
Compare
ggazzo
force-pushed
the
release-7.0.0
branch
2 times, most recently
from
May 9, 2024 23:07
495a17e to
a3e9e9b
Compare
ggazzo
force-pushed
the
release-7.0.0
branch
3 times, most recently
from
June 11, 2024 17:57
ea82dad to
7e69ab1
Compare
ggazzo
force-pushed
the
release-7.0.0
branch
3 times, most recently
from
June 24, 2024 11:48
bc4fad7 to
b484993
Compare
matheusbsilva137
force-pushed
the
fix/broken-forgot-password-mail
branch
from
October 8, 2024 19:13
a192f6b to
2d0fc01
Compare
sampaiodiego
force-pushed
the
release-7.0.0
branch
2 times, most recently
from
October 9, 2024 17:43
d1aa5f9 to
374979f
Compare
matheusbsilva137
force-pushed
the
fix/broken-forgot-password-mail
branch
from
October 9, 2024 20:18
2d0fc01 to
5ab31d2
Compare
MarcosSpessatto
suggested changes
Oct 9, 2024
* feat: New empty state for upgrading private Apps * chore: Change Marketplace info modal text (#33239) * feat: New tooltips and color behavior for private apps bar (#33243) * feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md * feat: new modal on Private Apps install (#33275) * feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md * chore: change grandfathered modal text (#33291) * chore: Use apps provider to check maxPrivateApps * fix: adds minor fixes to UI and changes requested on review * Update changeset * Replace negative boolean * Refactor `AppsUsageCard` * Add unit test for `AppsUsageCard` * Add unit test for `PrivateEmptyState` * Add unit test for `EnabledAppsCount` * Move tooltip logic away from `useAppsCountQuery` --------- Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
matheusbsilva137
force-pushed
the
fix/broken-forgot-password-mail
branch
from
October 10, 2024 17:39
b98bec3 to
d6bbea8
Compare
MarcosSpessatto
approved these changes
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fix: Update translation key used by 'Forgot Password' e-mail body setting --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
This was referenced Oct 20, 2024
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Forgot_Password_Emailsetting.Issue(s)
Introduced by #31343
Steps to test or reproduce
Start a workspace on 6.5 (or an older version), then update to the latest RC version. Then, check the e-mail received when triggering the "forgot password" flow.
Current behavior: the e-mail contains the text
Lets_get_you_new_one(not correctly translated key).Expected behavior: the e-mail should contain a translated text (such as "Let's get you a new one!") instead of a key.
Further comments
CORE-247