Repository navigation
fix: User roles selection not persisting on editing in users admin panel - #32671
Merged
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 71a3403 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32671 +/- ##
===========================================
+ Coverage 55.45% 55.52% +0.07%
===========================================
Files 2637 2635 -2
Lines 57316 57283 -33
Branches 11869 11873 +4
===========================================
+ Hits 31782 31809 +27
+ Misses 22836 22751 -85
- Partials 2698 2723 +25
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
Jun 26, 2024
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
Contributor
There was a problem hiding this comment.
Would it be possible to add some UI tests to ensure the behavior?
MarcosSpessatto
approved these changes
Jul 18, 2024
MartinSchoeler
approved these changes
Jul 23, 2024
MartinSchoeler
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
dionisio-bot
Bot
removed
the
stat: ready to merge
yash-rajpal
added
the
stat: ready to merge
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently when we edit user from admin user panel, we don't refetch the user details again on save, due to which the user edit form shows older info, like user roles. So now refetching the user info after saving the user.
Issue(s)
Steps to test or reproduce
Further comments
CORE-39