Skip to content

regression: fix Google OAuth - #33812

Merged
ggazzo merged 2 commits into
release-7.0.0from
regression-fix-google-oauth
Oct 28, 2024
Merged

ggazzo merged 2 commits into
release-7.0.0from
regression-fix-google-oauth

Conversation

@sampaiodiego

@sampaiodiego sampaiodiego commented Oct 28, 2024 •

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-772

@dionisio-bot

dionisio-bot Bot commented Oct 28, 2024 •

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Oct 28, 2024 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ae91633

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 28, 2024 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33812/
on branch gh-pages at 2024-10-28 19:14 UTC

@codecov

codecov Bot commented Oct 28, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (d1e14a0) to head (ae91633).
Report is 2 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33812      +/-   ##
=================================================
- Coverage          75.08%   74.96%   -0.13%     
=================================================
  Files                493      481      -12     
  Lines              21834    21044     -790     
  Branches            5458     5339     -119     
=================================================
- Hits               16395    15776     -619     
+ Misses              4792     4636     -156     
+ Partials             647      632      -15     
Flag Coverage Δ
unit 74.96% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@ggazzo ggazzo added this to the 7.0 milestone Oct 28, 2024
@ggazzo
ggazzo marked this pull request as ready for review October 28, 2024 19:34
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 28, 2024
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 28, 2024
@ggazzo
ggazzo merged commit a72c3ad into release-7.0.0 Oct 28, 2024
@ggazzo
ggazzo deleted the regression-fix-google-oauth branch October 28, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants