Skip to content

regression: fix wrong translations on marketplace - #33831

Merged
kodiakhq[bot] merged 3 commits into
release-7.0.0from
marketplace-modal-text
Oct 29, 2024
Merged

kodiakhq[bot] merged 3 commits into
release-7.0.0from
marketplace-modal-text

Conversation

@MartinSchoeler

@MartinSchoeler MartinSchoeler commented Oct 29, 2024 •

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Changes some translations values to reflect policies changed in 7.0.0 regarding app limits

Issue(s)

PASLR-39

Steps to test or reproduce

Further comments

@dionisio-bot

dionisio-bot Bot commented Oct 29, 2024 •

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Oct 29, 2024 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0f7db6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Oct 29, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (48493df) to head (0f7db6b).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33831   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AliNunes AliNunes added this to the 7.0 milestone Oct 29, 2024
@MartinSchoeler
MartinSchoeler changed the base branch from develop to release-7.0.0 October 29, 2024 20:46
@MartinSchoeler MartinSchoeler changed the title Marketplace modal text regression: fix wrong translations on marketplace Oct 29, 2024
@MartinSchoeler
MartinSchoeler marked this pull request as ready for review October 29, 2024 20:58
@github-actions

github-actions Bot commented Oct 29, 2024 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33831/
on branch gh-pages at 2024-10-29 22:49 UTC

@barbarazanellaa barbarazanellaa added the stat: QA assured Means it has been tested and approved by a company insider label Oct 29, 2024
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 29, 2024
@kodiakhq
kodiakhq Bot merged commit 180a446 into release-7.0.0 Oct 29, 2024
@kodiakhq
kodiakhq Bot deleted the marketplace-modal-text branch October 29, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants