Skip to content
This repository was archived by the owner on Mar 17, 2023. It is now read-only.

'Query' support for channels.list.joined, groups.list, groups.listAll, im.list - #515

Merged
MartinSchoeler merged 14 commits into
RocketChat:masterfrom
xbolshe:master
Feb 28, 2018
Merged

MartinSchoeler merged 14 commits into
RocketChat:masterfrom
xbolshe:master

Conversation

@xbolshe

@xbolshe xbolshe commented Jan 22, 2018

Copy link
Copy Markdown
Contributor

No description provided.

…, im.list (see PR #9424)

Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
@xbolshe

xbolshe commented Jan 22, 2018

Copy link
Copy Markdown
Contributor Author

See Rocket.Chat PR #9424 for details.

@@ -0,0 +1,55 @@
# Group List All

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this file to the Table of Contents

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

xbolshe and others added 10 commits January 26, 2018 23:09
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
@MartinSchoeler
MartinSchoeler dismissed their stale review February 22, 2018 13:15

it was already fixed

@@ -56,11 +56,61 @@ curl -H "X-Auth-Token: 9HqLlyZOugoStsXCUfD_0YdwnNnunAJF8V47U3QHXSq" \
],
"success": true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xbolshe, can you add the offset, count and total properties to this response object please?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems "t": "p" is incorrect for Direct Messages. I updated request/response using real Rocket Chat.

Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
@MartinSchoeler
MartinSchoeler merged commit a98543e into RocketChat:master Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants