Replace winapi usage with windows#218
Conversation
|
I don't know if there's any interest in a change like this. If there is, I'd be happy to spend a bit more time cleaning it up further. This replaces the need for #217. |
|
Hello, yes there is very much interest in a change like this! 😃 Right now the focus for baseview is to update those foundational dependencies (namely from There are some conflicts and CI issues that need to be fixed first. If you are still interested in working on this, those are the first changes to make before this can be merged. 🙂 Thank you for this PR! |
prokopyl
left a comment
prokopyl
left a comment
There was a problem hiding this comment.
(as stated above, need to fix CI issues and resolve conflicts)
|
I took the liberty of rebasing your PR onto the most recent main 🙂 |
prokopyl
force-pushed
the
windows-sys
branch
2 times, most recently
from
3bce932 to
828078b
Compare
The winapi crate is no longer maintained. This change ports everything over to use the more maintained windows crate.
…and to not change behavior as much compared to the winapi version
|
Checked the code and and tested on Windows 11, it all works and looks good to me. Thanks again! 🙂 |
|
@prokopyl - thanks for picking this up! Sorry I've not had a chance recently to work on my home projects! |
2 participants
The
winapicrate is no longer maintained. This change ports everything over to use thewindowscrate.