aes: make autodetect unions non-Copy; MSRV 1.49+#216
Merged
Conversation
tarcieri
force-pushed
the
aes/non-copy-unions
branch
6 times, most recently
from
December 3, 2020 23:42
6ed2aa7 to
b379238
Compare
tarcieri
changed the title
tarcieri
force-pushed
the
aes/non-copy-unions
branch
from
December 3, 2020 23:48
b379238 to
9949bf3
Compare
tarcieri
marked this pull request as ready for review
December 3, 2020 23:56
Member
Author
|
It works! 🎉 I wouldn't suggest merging until 1.49 stable is out, but in the meantime, it's nice to see this will be possible soon. |
Uses the new `core::mem::ManuallyDrop` feature to allow the inner types of unions to be non-Copy.
tarcieri
force-pushed
the
aes/non-copy-unions
branch
from
December 31, 2020 15:15
9949bf3 to
b898c89
Compare
Member
Author
|
Rust 1.49 is out 🎉 Merging this. |
tarcieri
added a commit
that referenced
this pull request
Dec 31, 2020
The tests are failing because the `aes` crate now uses `ManuallyDrop` unions which are MSRV 1.49 (see #216)
tarcieri
added a commit
that referenced
this pull request
Dec 31, 2020
The tests are failing because the `aes` crate now uses `ManuallyDrop` unions which are MSRV 1.49 (see #216)
tarcieri
added a commit
that referenced
this pull request
Dec 31, 2020
The tests are failing because the `aes` crate now uses `ManuallyDrop` unions which are MSRV 1.49 (see #216)
tarcieri
added a commit
that referenced
this pull request
Dec 31, 2020
The tests are failing because the `aes` crate now uses `ManuallyDrop` unions which are MSRV 1.49 (see #216)
Member
|
It creates a bit of a problem. Previously MSRV was bound by |
Member
Author
|
Yeah we can potentially add and CI for a lower MSRV with the Edit: done in #221. |
tarcieri
added a commit
to RustCrypto/stream-ciphers
that referenced
this pull request
Dec 31, 2020
The `aes` crate is used for several tests, and just got an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the git dependency to test the crates in this repo with the MSRV changes.
tarcieri
added a commit
to RustCrypto/stream-ciphers
that referenced
this pull request
Dec 31, 2020
The `aes` crate is used for several tests, and just got an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the git dependency to test the crates in this repo with the MSRV changes.
tarcieri
added a commit
to RustCrypto/stream-ciphers
that referenced
this pull request
Dec 31, 2020
tarcieri
added a commit
to RustCrypto/MACs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is used for several tests, and just got an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the git dependency to test the crates in this repo with the MSRV changes.
tarcieri
added a commit
to RustCrypto/MACs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is used for several tests, and just got an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the git dependency to test the crates in this repo with the MSRV changes.
tarcieri
added a commit
to RustCrypto/MACs
that referenced
this pull request
Dec 31, 2020
tarcieri
added a commit
to RustCrypto/AEADs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
tarcieri
added a commit
to RustCrypto/AEADs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
tarcieri
added a commit
to RustCrypto/AEADs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
tarcieri
added a commit
to RustCrypto/AEADs
that referenced
this pull request
Dec 31, 2020
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
Merged
dfvgbh
added a commit
to dfvgbh/stream-siphers
that referenced
this pull request
Oct 4, 2025
The `aes` crate is used for several tests, and just got an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the git dependency to test the crates in this repo with the MSRV changes.
zk-wraithbg67
added a commit
to zk-wraithbg67/stream-ciphers
that referenced
this pull request
Jan 11, 2026
The `aes` crate is used for several tests, and just got an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the git dependency to test the crates in this repo with the MSRV changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new
core::mem::ManuallyDropfeature to allow the inner types of unions to be non-Copy.