You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because we test minimal dependency versions as part of our CI tests, so downstream crates could pull aes v0.9.0 and incorrect version of zeroize which results in a compilation error since aes uses function introduced only in zeroize v1.8. So we either have to pin aes to v0.9.1 in all downstream crates or simply yank v0.9.0 as a "buggy" version.
It is quite disruptive to downstream CI as well
It should not be disruptive. If you commit Cargo.lock, then yanking should not affect you, if not, then v0.9.1 should be pulled by default.
It should not be disruptive. If you commit Cargo.lock, then yanking should not affect you,
huh, I was gonna say that it would specifically and explicitly affect folks who commit and install from Cargo.lock if said lockfile has v0.9.0 locked... but TIL cargo tolerates locked + yanked packages with a warning to avoid breakage apparently
Cargo will not use a yanked version for any new project or checkout without a pre-existing lockfile, and will generate an error if there are no longer any compatible versions for your crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
zeroizedependency (#562)