cipher+digest: migrate to hybrid array; MSRV 1.65#1358
Merged
Conversation
tarcieri
force-pushed
the
cipher+digest/hybrid-array
branch
2 times, most recently
from
October 8, 2023 22:27
2c457b6 to
fb64380
Compare
Member
Author
|
@newpavlov well, there's the next step |
Replaces `generic-array` with `hybrid-array`, which is built on a combination of `typenum` and const generics, providing a degree of interoperability between the two systems. `hybrid-array` is designed to be a largely drop-in replacement, and the number of changes required to switch are relatively minimal aside from some idiosyncrasies.
tarcieri
force-pushed
the
cipher+digest/hybrid-array
branch
from
October 27, 2023 00:50
fb64380 to
f93a1d6
Compare
tarcieri
changed the title
newpavlov
reviewed
Oct 27, 2023
| /// of zero and tail is equal to `self`. | ||
| #[inline] | ||
| fn into_chunks<T, N: ArrayLength<T>>(buf: &mut [T]) -> (&mut [GenericArray<T, N>], &mut [T]) { | ||
| fn into_chunks<T, N: ArraySize>(buf: &mut [T]) -> (&mut [Array<T, N>], &mut [T]) { |
Member
There was a problem hiding this comment.
Maybe we should move this method into hybrid-array? I think we had a recent discussion about it.
Member
Author
There was a problem hiding this comment.
Sure, although perhaps that could be a followup?
tarcieri
marked this pull request as ready for review
October 27, 2023 01:11
newpavlov
approved these changes
Oct 27, 2023
This was referenced Sep 18, 2024
Merged
tarcieri
added a commit
that referenced
this pull request
Feb 4, 2026
### Added - Traits for tweakable block ciphers (#1721) - Methods for writing keystream (#1907) ### Changed - Replaced `generic-array` with `hybrid-array` (#1358) - Rename `BlockCipher*`/`BlockMode*` (#1482) - `BlockEncrypt` => `BlockCipherEncrypt` - `BlockDecrypt` => `BlockCipherDecrypt` - `BlockEncryptMut` => `BlockModeEncrypt` - `BlockDecryptMut` => `BlockModeDecrypt` - Split `BlockBackend` traits into 4 specific traits: (#1636) - `BlockCipherEncBackend` - `BlockCipherDecBackend` - `BlockModeEncBackend` - `BlockModeDecBackend` - Edition changed to 2024 and MSRV bumped to 1.85 (#1759) - Use `block_buffer::ReadBuffer` in `StreamCipherCoreWrapper` (#1959) - Re-export of `crypto-common` moved to `cipher::common` (#2237, #2260) - `crypto-common` dependency bumped to v0.2 (#2276) - `blobby` requirement bumped to v0.4 (#2147) - `inout` dependency bumped to v0.2.2 (#2149) ### Fixed - Bugs in `StreamCipherCoreWrapper` trait implementations (#1421) - Seeking implementation in the stream cipher wrapper (#2052) ### Removed - `std` feature (#1691) - `BlockCipherEncrypt::encrypt_padded*` and `BlockCipherDecrypt::decrypt_padded*` methods. Users of the ECB mode should use the `ecb-mode` crate instead. (#2245) - `AsyncStreamCipher` trait (#2280)
Merged
tarcieri
added a commit
that referenced
this pull request
Feb 13, 2026
## Added - `CustomizedInit` trait (#1334) - `SerializableState` support (#1369) - `DynDigestWithOid` wrapper trait (#1390) - `VariableOutputCoreCustomized` trait (#1787, #2043) - `buffer_fixed`, `buffer_ct_variable`, `buffer_rt_variable`, and `buffer_xof` macros (#1799) - `XofFixedWrapper` (#1815) - `CollisionResistance` trait (#1820) - `CoreProxy::compose/decompose` methods (#1898) - `EagerHash` trait (#2014) ## Changed - Replaced `generic-array` with `hybrid-array` (#1358) - `crypto-common` dependency bumped to v0.2 (#1173) - Edition changed to 2024 and MSRV bumped to 1.85 (#1759) - Bump `const-oid` dependency to v0.10 (#1772) - `digest::core_api` renamed to `digest::block_api` (#1799) - `CtVariableCoreWrapper` renamed to `CtOutWrapper` (#1799) - Removed the OID type parameter from `CtOutWrapper` (#1799) - Implementations of the `SerializableState` trait (#1953) - `new_test!` and `new_mac_test!` macros (#1958) - Bump `block-buffer` to v0.11 (#2082) - Re-export of `crypto-common` moved to `digest::common` (#2237) - Bump `crypto-common` to v0.2 (#2276) - Replace `subtle` with `ctutils` (#2301) ## Removed - `Mac::{new, new_from_slice, generate_key}` methods (#1173) - `CoreWrapper`, `RtVariableCoreWrapper`, and `XofReaderCoreWrapper` types (#1799) - `io::Write/Read` implementations in favor of the `digest_io::IoWrapper` type (#1809) - `VariableOutput` trait (#2043) - Implementation of `subtle::ConstantTimeEq` for `CtOutput`. Note that implementation of `PartialEq`/`Eq` trait is still const time. (#2292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #1319.
Replaces
generic-arraywithhybrid-array, which is built on a combination oftypenumand const generics, providing a degree of interoperability between the two systems.hybrid-arrayis designed to be a largely drop-in replacement, and the number of changes required to switch are relatively minimal aside from some idiosyncrasies.