fix(ui): guard registerOpenCodeTheme against duplicate registration - #20
Merged
Conversation
Called from both context/marked.tsx and the Shiki worker pool (worker.ts) to guarantee the theme is registered before either needs it. Without the guard, both call sites re-running registerCustomTheme repeatedly is harmless but wasteful.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
registerOpenCodeTheme()is called from bothcontext/marked.tsxand the Shiki worker pool (worker.ts) to guarantee the theme is registered before either needs it. Without a guard, both call sites re-runningregisterCustomThemerepeatedly is harmless but wasteful — this adds a module-level flag so it only registers once.How did you verify your code works?
Small, self-contained change; verified
bun run typecheckstays clean onpackages/ui.Screenshots / recordings
Not applicable — internal idempotency guard, no visible behavior change.
Checklist