Conversation
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some model docs were not putting text strings equations within
\textor\mathrmwrappers.There was an occasional misplaced
&symbol in equations.The references were not always bullet numbered.
An obscure error:
#. L. Onsager ...was rendering as1. 12. Onsager ...because theL.was being treated as an enumerationA. B. C. ...by the reStructuredText parser. The solution was to change it to#. L Onsager ...or#. \L. Onsager ..., depending on the style of the other references in the model.The final "where ..." block in
spherical_sldis complaining about embedded equations on some latex renderers. The equation works when I use it as input for the online KaTeX and MathJax demos so it will probably work here, but we need to check that page in built docs before merging.Note that this contains an alternate fix to #754, removing the unicode symbols from the C source. That wasn't intended for this PR, but it won't hurt either so I'll leave it.