Skip to content

Ignore extras-only Aqua stale_deps in run_qa - #222

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/ignore-extras-stale-deps
Aug 15, 2026
Merged

Ignore extras-only Aqua stale_deps in run_qa#222
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/ignore-extras-stale-deps

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Please ignore this PR until it has been reviewed by @ChrisRackauckas.

What changed

test/qa/qa.jl now passes Aqua stale_deps ignores for SafeTestsets and SciMLTesting through run_qa's aqua_kwargs. No package version or [compat] change.

Why

Default-branch Downgrade is red while Tests are green (run). run_qa(DiffEqProblemLibrary) runs Aqua against the extras-merged sandbox. SafeTestsets and SciMLTesting live in root [extras] (test harness only) and are flagged as stale deps.

SciMLTesting 2.4–2.9 run_qa does not auto-ignore extras. Aqua's stale_deps = (; ignore = ...) is the supported per-check API. Other Aqua checks are unchanged.

Verification

CI fail-before (Aqua 0.8.16):

Stale dependencies: Test Failed
  Expression: isempty(stale_deps)
  Evaluated: isempty(Base.PkgId[SafeTestsets [...], SciMLTesting [...]])

run_qa forwards aqua_kwargs to Aqua.test_all (SciMLTesting 2.4+).

Not verified here: a live julia-downgrade-compat re-run of the full Core group.

Reviewer note

This is a test-only Aqua ignore for extras that are not package deps. A [compat] bump cannot fix extras-merge stale_deps.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review August 15, 2026 10:50
@ChrisRackauckas
ChrisRackauckas merged commit 08a8387 into SciML:master Aug 15, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants