add cpvm

[iceljc]

No description provided.

[iceljc]

@kerryjiang
Hi, we cannot compile the code after merging your previous pull request regarding the centralized package version management.
So I reverted that pull request, and proposal this one instead.

Can you help to take a look and make sure the projects are compliable and runnable?
Thanks!

[kerryjiang]

What's the error you got? It should be only about BotSharp internal package version management. Usually, it won't impact the things which depends on it. Probably there is assembly version conflict issue over there, but it is covered by current inconsistent package versions.

Just tell me what problem you got.

@iceljc

[iceljc]

What's the error you got? It should be only about BotSharp internal package version management. Usually, it won't impact the things which depends on it. Probably there is assembly version conflict issue over there, but it is covered by current inconsistent package versions.

Just tell me what problem you got.

@iceljc

For example:

Projects that use central package version management should not define the version on the PackageReference items but on the PackageVersion items: NAudio.Core;Whisper.net.Runtime;Microsoft.AspNetCore.Mvc;NAudio;Whisper.net.

I follow the official doc and change some syntax in Directory.Packages.props file. Then it works.
https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management

@kerryjiang

[kerryjiang]

Oh, yes.

I see PackageReference => PackageVersion. That was my typo or did wrong global replacement.

But how did build pass?

[kerryjiang]

Something wrong with the build:
https://ci.appveyor.com/project/Haiping-Chen/botsharp/builds/51435397

Even the build for this PR:
https://ci.appveyor.com/project/Haiping-Chen/botsharp/builds/51467610

@haiping-chen

[kerryjiang]

@haiping-chen it seems the build doesn't work correctly.

[iceljc]

@kerryjiang

Is the build successful on your local with the changes in this PR? or any issues?

[kerryjiang]

I didn't, because I had problem to build BotSharp on my Macbook.

[iceljc]

What is the error when building on macbook?

[kerryjiang]

@iceljc added github pr build pipeline, could you fix the merge conflict? And see how will the build for this PR go.

[iceljc]

@kerryjiang done. seems all passed. We will merge the pull requests after next Tuesday.