Repository navigation
Temporary fix to ensure coordinate realisation during pp load - #6767
Merged
Merged
Conversation
…ates during pp load
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6767 +/- ##
==========================================
+ Coverage 90.30% 90.37% +0.06%
==========================================
Files 91 91
Lines 24674 24746 +72
Branches 4623 4635 +12
==========================================
+ Hits 22282 22363 +81
+ Misses 1620 1610 -10
- Partials 772 773 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
stephenworsley
marked this pull request as ready for review
October 30, 2025 12:17
pp-mo
requested changes
Oct 30, 2025
pp-mo
left a comment
Member
There was a problem hiding this comment.
The mechanics looks fine, and I'm sure it works.
Some suggestions though about : increasing user clarity; supporting permanent setting; testing for both cases
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
pp-mo
enabled auto-merge (squash)
October 30, 2025 17:11
pp-mo
approved these changes
Oct 30, 2025
Member
|
Thanks @stephenworsley . All good now, I think. I had previously sort-of skipped over the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #6755 (until a better solution is implemented).