Skip to content

Fix TEST_DATA_DIR default behaviour - #7257

Merged
trexfeathers merged 2 commits into
SciTools:mainfrom
stephenworsley:TEST_DATA_DIR-fix
Aug 20, 2026
Merged

Fix TEST_DATA_DIR default behaviour#7257
trexfeathers merged 2 commits into
SciTools:mainfrom
stephenworsley:TEST_DATA_DIR-fix

Conversation

@stephenworsley

@stephenworsley stephenworsley commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Bug with TEST_DATA_DIR seems to have been introduced with #7087. This PR reverts to the previous behaviour.

@codecov

codecov Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.42%. Comparing base (15f9f2b) to head (56508ee).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7257   +/-   ##
=======================================
  Coverage   90.42%   90.42%           
=======================================
  Files          93       93           
  Lines       25812    25812           
  Branches     4795     4795           
=======================================
  Hits        23340    23340           
  Misses       1693     1693           
  Partials      779      779

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephenworsley
stephenworsley marked this pull request as ready for review August 20, 2026 10:32
trexfeathers
trexfeathers approved these changes Aug 20, 2026
View reviewed changes

@trexfeathers trexfeathers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@trexfeathers
trexfeathers enabled auto-merge (squash) August 20, 2026 10:37
@trexfeathers
trexfeathers merged commit c13dac8 into SciTools:main Aug 20, 2026
22 checks passed
@scitools-ci scitools-ci Bot removed this from 🚴 Peloton Sep 18, 2026
stephenworsley added a commit that referenced this pull request Sep 18, 2026
@pp-mo @HGWright
@trexfeathers @01luyicheng @dependabot @stephenworsley @mo-AndrewCreswick @ESadek-MO @web-flow @rcomer
Encoding for the ncdata "shortcut" datapaths (#7281)
70cdd63 
* undo the whatsnew changes

* fix for doctest warnings

* Add unit tests for Cube.coord_dims (#7198)

* Add unit tests for Cube.coord_dims

* Add What's New changelog fragment for #4552

* Refactor Test_coord_dims._setup for readability

Address review feedback from @ESadek-MO:
- Move hybrid-height set-up into the single test that uses it
- Group _setup into clear blocks: cube → DimCoords → AuxCoords → assigns

* Move hybrid-height set-up into a dedicated fixture

Address review feedback from @ESadek-MO on #7198: move the hybrid-height
construction (delta/sigma/orography, HybridHeightFactory, add_aux_factory)
out of the test body and into its own pytest fixture, so that set-up
failures can be isolated by PyTest.

---------

Co-authored-by: 01luyicheng <01luyicheng@users.noreply.github.com>

* Bump the gha group across 1 directory with 9 updates (#7215)

Bumps the gha group with 9 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [actions/checkout](https://github.com/actions/checkout) | `7.0.0` | `7.0.1` |
| [actions/setup-python](https://github.com/actions/setup-python) | `6.3.0` | `7.0.0` |
| [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) | `2.8.0` | `2.9.0` |
| [scitools/workflows/.github/workflows/ci-manifest.yml](https://github.com/scitools/workflows) | `2026.06.0` | `2026.07.1` |
| [scitools/workflows/.github/workflows/ci-template-check.yml](https://github.com/scitools/workflows) | `2026.06.0` | `2026.07.1` |
| [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) | `1.14.0` | `1.14.2` |
| [actions/labeler](https://github.com/actions/labeler) | `6.1.0` | `7.0.0` |
| [scitools/workflows/.github/workflows/refresh-lockfiles.yml](https://github.com/scitools/workflows) | `2026.06.0` | `2026.07.1` |
| [actions/stale](https://github.com/actions/stale) | `10.3.0` | `11.0.0` |



Updates `actions/checkout` from 7.0.0 to 7.0.1
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@9c091bb...3d3c42e)

Updates `actions/setup-python` from 6.3.0 to 7.0.0
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@ece7cb0...5fda3b9)

Updates `lycheeverse/lychee-action` from 2.8.0 to 2.9.0
- [Release notes](https://github.com/lycheeverse/lychee-action/releases)
- [Commits](lycheeverse/lychee-action@8646ba3...e747777)

Updates `scitools/workflows/.github/workflows/ci-manifest.yml` from 2026.06.0 to 2026.07.1
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@1f21414...7c41342)

Updates `scitools/workflows/.github/workflows/ci-template-check.yml` from 2026.06.0 to 2026.07.1
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@1f21414...7c41342)

Updates `pypa/gh-action-pypi-publish` from 1.14.0 to 1.14.2
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@cef2210...dc37677)

Updates `actions/labeler` from 6.1.0 to 7.0.0
- [Release notes](https://github.com/actions/labeler/releases)
- [Commits](actions/labeler@f27b608...bf12e9b)

Updates `scitools/workflows/.github/workflows/refresh-lockfiles.yml` from 2026.06.0 to 2026.07.1
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@1f21414...7c41342)

Updates `actions/stale` from 10.3.0 to 11.0.0
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@eb5cf3a...4391f3d)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 7.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gha
- dependency-name: actions/labeler
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gha
- dependency-name: actions/setup-python
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gha
- dependency-name: actions/stale
  dependency-version: 10.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gha
- dependency-name: lycheeverse/lychee-action
  dependency-version: 2.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gha
- dependency-name: pypa/gh-action-pypi-publish
  dependency-version: 1.14.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gha
- dependency-name: scitools/workflows/.github/workflows/ci-manifest.yml
  dependency-version: 2026.07.1
  dependency-type: direct:production
  dependency-group: gha
- dependency-name: scitools/workflows/.github/workflows/ci-template-check.yml
  dependency-version: 2026.07.1
  dependency-type: direct:production
  dependency-group: gha
- dependency-name: scitools/workflows/.github/workflows/refresh-lockfiles.yml
  dependency-version: 2026.07.1
  dependency-type: direct:production
  dependency-group: gha
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the gha group across 1 directory with 3 updates (#7256)

Bumps the gha group with 3 updates in the / directory: [scitools/workflows/.github/workflows/ci-manifest.yml](https://github.com/scitools/workflows), [scitools/workflows/.github/workflows/ci-template-check.yml](https://github.com/scitools/workflows) and [scitools/workflows/.github/workflows/refresh-lockfiles.yml](https://github.com/scitools/workflows).


Updates `scitools/workflows/.github/workflows/ci-manifest.yml` from 2026.07.1 to 2026.08.1
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@7c41342...28aea7a)

Updates `scitools/workflows/.github/workflows/ci-template-check.yml` from 2026.07.1 to 2026.08.1
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@7c41342...28aea7a)

Updates `scitools/workflows/.github/workflows/refresh-lockfiles.yml` from 2026.07.1 to 2026.08.1
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@7c41342...28aea7a)

---
updated-dependencies:
- dependency-name: scitools/workflows/.github/workflows/ci-manifest.yml
  dependency-version: 2026.08.1
  dependency-type: direct:production
  dependency-group: gha
- dependency-name: scitools/workflows/.github/workflows/ci-template-check.yml
  dependency-version: 2026.08.1
  dependency-type: direct:production
  dependency-group: gha
- dependency-name: scitools/workflows/.github/workflows/refresh-lockfiles.yml
  dependency-version: 2026.08.1
  dependency-type: direct:production
  dependency-group: gha
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix TEST_DATA_DIR default behaviour (#7257)

* fix TEST_DATA_DIR default behaviour

* add whatsnew

* Add option for steps in Cube rolling windows (#7236)

* Add option for steps in Cube rolling windows

* Add changelog entry

* Fix bug with mesh indexing for start_index=1 (#7253)

* fix bug with mesh indexing for start_index=1

* add test

* add whatsnew

* add unit tests

* CI compatibility with PROJ 9.8 (#7254)

* CI compatibility with PROJ 9.8.

* review comments (#97)

---------

Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>

* Update lock files plus test fixes (#7270)

* Updated environment lockfiles

* Temporary gallery test fix.

* Revert "Temporary gallery test fix."

This reverts commit 6403701.

* Skip Proj 9.8 incompatible gallery tests. Proven by 6403701.

* Modernise graphics tests.

* What's New entry.

---------

Co-authored-by: Lockfile bot <noreply@github.com>
Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>

* DOC BLD: get scipy objects inventory from their static site (#7269)

* Move developers' conda yml to environment.yml (#7267)

* Move developers' conda yml to environment.yml

* Fix readthedocs.yml

* Add environment.yml to manifest

* Add code trial for encode/decode of lazy data.

* Some extra debug.

* Apply encode/decode to load/save shortcutting, and support lazy data.

* Small changes to support scalar character variables.

* Replace complex VariableEncoder constructor with a .from_var classmethod.

* Apply scalar adjustment whether lazy or real.

* Remove debug print.

* Extend get_cf_var to test dataset-shortcutting of strings and real/lazy data.

* Fix typo in tests.

* Remove temporary tests.

* With CoPilot: tests for handling of ncdata-style direct data transfers in '_lazy_stream_data'.

* Added changelog fragment.

* Review changes.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Henry Wright <henrywright@sky.com>
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Co-authored-by: 陆奕丞 <01luyicheng@gmail.com>
Co-authored-by: 01luyicheng <01luyicheng@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stephenworsley <49274989+stephenworsley@users.noreply.github.com>
Co-authored-by: Andrew Creswick <89418171+mo-AndrewCreswick@users.noreply.github.com>
Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>
Co-authored-by: Lockfile bot <noreply@github.com>
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
pp-mo pushed a commit to pp-mo/iris that referenced this pull request Sep 22, 2026
@stephenworsley @pp-mo
Fix TEST_DATA_DIR default behaviour (SciTools#7257)
431c44d 
* fix TEST_DATA_DIR default behaviour

* add whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephenworsley @trexfeathers