Repository navigation
ci: reuse exact merge-queue qualification on main - #582
Merged
Merged
Conversation
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Both jobs now also need queue_ci and are skipped when main reuses the queue's qualification; their workflow tests still expected the old needs and conditions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Codex review, round 1 (gpt-6.1-sol, high reasoning, read-only)Verdict on
Since the previous head: current 🤖 Generated with Claude Code |
yaacovcorcos
marked this pull request as ready for review
October 19, 2026 08:13
yaacovcorcos
pushed a commit
that referenced
this pull request
Oct 19, 2026
Catches up owned main with Scient PRs #582 (CI exact-commit reuse), #595 (Antigravity and one-click provider sign-in), #568, #569, #570 (Oh My Pi resume, status, multi-question sign-in), #583 and #594. - #582's reuse gate and its test no longer require the Test Web layout job, which this alignment retired with upstream's move to browser tests. - #595's sign-in flow is carried into the React Compiler conversion of the provider-connection files: plain values and functions instead of useMemo/useCallback, conditionals outside try blocks, and the controller's authorization page delegated to #595's shared opener. - The CI guide names the browser coverage that replaced the layout job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main-push CI currently repeats expensive suites immediately after merge-queue CI validated the identical commit. This change reuses successful queue qualification only when the commit, comparison base, repository, workflow revision, and run attempt all match. Missing or invalid evidence runs full CI.
Behavior
merge_grouprun of this workflow. It validates the receipt and all seven reporting artifacts, and rechecks the source attempt after downloading them.thread-transfer-resultsand the six Vitest JSON reports are republished with their normal names and destination attempt. Reuse becomes active only after every upload succeeds; partial publication falls back to full CI, whose uploads replace any partially restored artifacts.Testlinks to the source qualification, andTransfer report artifactverifies the restored measurement. Branch protection is unchanged.Verification
Reviewed revision:
f7bbfcd22c2427b0e290bdf2039b148b7de33e5d, based directly on main172f8a8099084dc470862679fbd0e7b71fec8bba. Local environment: macOS arm64, Node 24.19.0, pnpm 11.10.0.Passed:
git diff --check.pnpm exec vp fmt --check,pnpm exec vp lint --report-unused-disable-directives(existing warnings),pnpm run knip:check,pnpm run typecheck,pnpm run build, andpnpm run test:desktop-smoke.Qualification gaps:
pnpm run teststopped at the unchangedpackages/shared/src/nodeSqliteClient.test.ts:181: “keeps large text and blob parameters off cached statements” returnednullinstead of65537. The isolated file reproduces the same failure (30 passing, 1 failing). The implementation, test, package manifest, and lockfile are identical to main. This PR does not change SQLite behavior; the full local suite is not green.Documentation impact: Updated —
docs/internals/ci.mddescribes eligibility, artifact preservation, fallback, and the unchanged checks.Model and harness: GPT-6 / Codex desktop, with independent subagent review.
Draft for owner review. Do not merge or enable auto-merge as part of this task.