Skip to content

fix(release): keep the unsigned-Windows notice out of release notes - #590

Merged
yaacovcorcos merged 1 commit into
mainfrom
claude/release-notes-no-windows-notice-20261018
Oct 18, 2026
Merged

yaacovcorcos merged 1 commit into
mainfrom
claude/release-notes-no-windows-notice-20261018

Conversation

@yaacovcorcos

Copy link
Copy Markdown
Contributor

What Changed

The release workflow no longer adds the unsigned-Windows notice to the GitHub release body. When allow_unsigned_windows=true, the exception now goes to the publish step's job summary instead. docs/operations/release.md says where the record lives and why. The publication rehearsal test now checks that a Beta body stays empty and that the summary records the exception.

Why

The desktop app shows a release's body as its release notes. Beta releases are published without notes on purpose, so the notice was the only text. The sidebar's update card showed it under What's changed, on macOS too. It read as a change list that described no changes.

The install guide (docs/user/install.md) already explains the SmartScreen warning for people downloading the installer. With an empty body, the update control falls back to its plain tooltip: "Update ready to download" and the version.

The change applies to releases published from now on. Existing releases, including the current Beta, keep their bodies.

Documentation Impact

Documentation impact: Updated — docs/operations/release.md (where the unsigned-Windows exception is recorded).

UI Changes

None in code. Future Beta update cards no longer show a "What's changed" section holding only the Windows notice.

Verification

  • I ran the changed shell lines under Bash. With empty notes and allow_unsigned_windows=true, the body file is empty and the summary records the exception.
  • vp fmt --check and git diff --check pass.
  • Not run locally: scripts/scient-beta-publication.test.ts skips on Windows by design, as Linux-only Bash fixtures. Linux CI runs it.

🤖 Generated with Claude Code

The app shows a release's body as its release notes. Beta releases have
no notes, so the appended unsigned-Windows notice was the only text and
the update card showed it under "What's changed", on every platform.

Record the exception in the run's job summary instead. The install guide
already explains the SmartScreen warning. With an empty body the update
control falls back to its plain tooltip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Oct 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.6 KiB 5.6 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 4.3 KiB 4.3 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 26.2 KiB 26.2 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.6 KiB 5.6 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 4.3 KiB 4.3 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 26.6 KiB 26.6 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 8f6c479 · PR result: 9cae3ee · Source CI: failure

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Full compact HTTP snapshot with live cursor.

  • Codex decoded thread snapshot: 133.1 KiB
  • Claude decoded thread snapshot: 133.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yaacovcorcos
yaacovcorcos added this pull request to the merge queue Oct 18, 2026
Merged via the queue into main with commit fdf0391 Oct 18, 2026
33 of 34 checks passed
@yaacovcorcos
yaacovcorcos deleted the claude/release-notes-no-windows-notice-20261018 branch October 18, 2026 22:25
yaacovcorcos pushed a commit that referenced this pull request Oct 19, 2026
Carries owned main a8a3cae onto the aligned tree. The sidebar update
controls (#585) are composed with upstream's update-everything changes:
provider statuses come from the live provider subscriptions now that server
configs omit them, and the new code follows the React Compiler rules. Its
React tests run in Chromium like the rest of the web suite.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant