Repository navigation
fix(release): keep the unsigned-Windows notice out of release notes - #590
Merged
yaacovcorcos merged 1 commit intoOct 18, 2026
Merged
Conversation
The app shows a release's body as its release notes. Beta releases have no notes, so the appended unsigned-Windows notice was the only text and the update card showed it under "What's changed", on every platform. Record the exception in the run's job summary instead. The install guide already explains the SmartScreen warning. With an empty body the update control falls back to its plain tooltip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
yaacovcorcos
deleted the
claude/release-notes-no-windows-notice-20261018
branch
October 18, 2026 22:25
yaacovcorcos
pushed a commit
that referenced
this pull request
Oct 19, 2026
Carries owned main a8a3cae onto the aligned tree. The sidebar update controls (#585) are composed with upstream's update-everything changes: provider statuses come from the live provider subscriptions now that server configs omit them, and the new code follows the React Compiler rules. Its React tests run in Chromium like the rest of the web suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The release workflow no longer adds the unsigned-Windows notice to the GitHub release body. When
allow_unsigned_windows=true, the exception now goes to the publish step's job summary instead.docs/operations/release.mdsays where the record lives and why. The publication rehearsal test now checks that a Beta body stays empty and that the summary records the exception.Why
The desktop app shows a release's body as its release notes. Beta releases are published without notes on purpose, so the notice was the only text. The sidebar's update card showed it under What's changed, on macOS too. It read as a change list that described no changes.
The install guide (
docs/user/install.md) already explains the SmartScreen warning for people downloading the installer. With an empty body, the update control falls back to its plain tooltip: "Update ready to download" and the version.The change applies to releases published from now on. Existing releases, including the current Beta, keep their bodies.
Documentation Impact
Documentation impact: Updated —
docs/operations/release.md(where the unsigned-Windows exception is recorded).UI Changes
None in code. Future Beta update cards no longer show a "What's changed" section holding only the Windows notice.
Verification
allow_unsigned_windows=true, the body file is empty and the summary records the exception.vp fmt --checkandgit diff --checkpass.scripts/scient-beta-publication.test.tsskips on Windows by design, as Linux-only Bash fixtures. Linux CI runs it.🤖 Generated with Claude Code